* Re: master 28358db930 1/2: Fix loaddefs generation
[not found] ` <20220601102558.E4719C05808@vcs2.savannah.gnu.org>
@ 2022-06-01 10:43 ` Lars Ingebrigtsen
2022-06-01 10:47 ` Lars Ingebrigtsen
2022-06-01 10:50 ` Po Lu
0 siblings, 2 replies; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-06-01 10:43 UTC (permalink / raw)
To: emacs-devel; +Cc: Po Lu
Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
> (delete-region (match-beginning 0)
> - (and (search-forward "\n\f\n;;;")
> + (and (search-forward "\n\f\n;;;" nil t)
> (match-beginning 0)))
That will make delete-region be called with a nil if the search-forward
fails. But it shouldn't fail -- if it fails, there loaddefs file is
corrupted.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: master 28358db930 1/2: Fix loaddefs generation
2022-06-01 10:43 ` master 28358db930 1/2: Fix loaddefs generation Lars Ingebrigtsen
@ 2022-06-01 10:47 ` Lars Ingebrigtsen
2022-06-01 10:50 ` Po Lu
1 sibling, 0 replies; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-06-01 10:47 UTC (permalink / raw)
To: emacs-devel; +Cc: Po Lu
Lars Ingebrigtsen <larsi@gnus.org> writes:
> But it shouldn't fail -- if it fails, there loaddefs file is
> corrupted.
Or there's old-style loaddefs.el files in there. Sorry, I forgot to
mention that a "make bootstrap" or "make -C lisp autoloads-force" is
necessary after updating, unfortunately.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 28358db930 1/2: Fix loaddefs generation
2022-06-01 10:43 ` master 28358db930 1/2: Fix loaddefs generation Lars Ingebrigtsen
2022-06-01 10:47 ` Lars Ingebrigtsen
@ 2022-06-01 10:50 ` Po Lu
2022-06-01 10:57 ` Lars Ingebrigtsen
1 sibling, 1 reply; 5+ messages in thread
From: Po Lu @ 2022-06-01 10:50 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
Lars Ingebrigtsen <larsi@gnus.org> writes:
> That will make delete-region be called with a nil if the search-forward
> fails. But it shouldn't fail -- if it fails, there loaddefs file is
> corrupted.
The build kept failing with a `search-failed' error before this change.
I don't know that code very well, but allowing it to fail did fix the
bug.
I'm not sure how to fix that properly. Would it suffice to simply not
call `delete-region' should the search fail?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 28358db930 1/2: Fix loaddefs generation
2022-06-01 10:50 ` Po Lu
@ 2022-06-01 10:57 ` Lars Ingebrigtsen
2022-06-01 10:59 ` Po Lu
0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-06-01 10:57 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
Po Lu <luangruo@yahoo.com> writes:
> The build kept failing with a `search-failed' error before this change.
> I don't know that code very well, but allowing it to fail did fix the
> bug.
>
> I'm not sure how to fix that properly. Would it suffice to simply not
> call `delete-region' should the search fail?
The problem is with mixing old-style loaddefs files with new ones, so
the previous error was correct. I've now tweaked the process so that it
should regenerate all the loaddefs files when loaddefs-gen changes.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-01 10:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <165407915849.23252.1559301725793524980@vcs2.savannah.gnu.org>
[not found] ` <20220601102558.E4719C05808@vcs2.savannah.gnu.org>
2022-06-01 10:43 ` master 28358db930 1/2: Fix loaddefs generation Lars Ingebrigtsen
2022-06-01 10:47 ` Lars Ingebrigtsen
2022-06-01 10:50 ` Po Lu
2022-06-01 10:57 ` Lars Ingebrigtsen
2022-06-01 10:59 ` Po Lu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).