From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Deprecation of define-key? Date: Sat, 30 Jul 2022 11:46:23 +0000 Message-ID: <871qu2lt68.fsf@fau.de> References: <875yjgszm4.fsf@posteo.net> <87mtcr99mx.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31981"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 30 13:48:15 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHkx5-00088o-Aj for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Jul 2022 13:48:15 +0200 Original-Received: from localhost ([::1]:52936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oHkx4-0007Er-BF for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Jul 2022 07:48:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHkvT-0005mp-2P for emacs-devel@gnu.org; Sat, 30 Jul 2022 07:46:35 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:46647) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHkvQ-0003xY-CD for emacs-devel@gnu.org; Sat, 30 Jul 2022 07:46:34 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id AA8E4240027 for ; Sat, 30 Jul 2022 13:46:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1659181589; bh=ujmsW0iB7dUnFCLKrREUPzP8leRAH+50TXJCq6Esams=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=iLjIDA3aqOTun7mUfNFtiAm7NXI32ezmY0l4OPmur26Jmz+N+QQy6UxQ/rI7dY5e8 fApli3uMmSg+L2N4LlbTHI/etYQz+G/HOSW5aMOSTO3yDD4xdf4Y8jKA0fBnDkIEuF 0ASPhJpxUsFmfc+/Y9BnnvKE70+Mmjj1lf41wLAfgzzl7bG5XqttAzREVwD2sa37fr MkRW8GPQYvT5fPzlbWHHVOlccc+q7aiktghk2GjdI547IpNmPG017jlbcBKKoobhUv ydRTLhrNizzs3+rpe8ngR33S7rzZPJp/rFvUV1kFy5Jk4OmdQo5HgT8H7U9QMpt1wc W46KM3/uz88cQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Lw2fB2JQFz6tpX; Sat, 30 Jul 2022 13:46:23 +0200 (CEST) In-Reply-To: <87mtcr99mx.fsf@igel.home> (Andreas Schwab's message of "Fri, 29 Jul 2022 18:16:54 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292867 Archived-At: Andreas Schwab writes: > On Jul 29 2022, Philip Kaludercic wrote: > >> The docstring for `define-key' currently says: >> >> This is a legacy function; see =E2=80=98keymap-set=E2=80=99 for = the recommended >> function to use instead. >> >> yet `keymap-set' uses `define-key' internally. Is there a long-term >> plan to re implement parts of keymap.el in C? >> >> If not, this should be rephrased (my understanding up until now was that >> keymap-* is a higher-level abstraction) > > I don't see any need. The use of define-key in keymap-set is an > implementation detail. That is obvious, the question is should package developers avoid using `define-key' if possible or not?