From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master 101f3cf5b9: Add support for user edits to VC command arguments Date: Thu, 22 Sep 2022 14:18:18 -0700 Message-ID: <871qs3kt0l.fsf@melete.silentflame.com> References: <166378878197.3568.7077863090259744101@vcs2.savannah.gnu.org> <20220921193303.1B687C11D81@vcs2.savannah.gnu.org> <87v8pfbw1g.fsf@gmail.com> <87edw3o0hs.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38942"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Robert Pluim , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 22 23:19:34 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obTba-0009yV-Aa for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Sep 2022 23:19:34 +0200 Original-Received: from localhost ([::1]:44614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1obTbZ-0004dm-5H for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Sep 2022 17:19:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obTaU-0003Dd-PF for emacs-devel@gnu.org; Thu, 22 Sep 2022 17:18:26 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:58175) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obTaQ-0003YA-GO for emacs-devel@gnu.org; Thu, 22 Sep 2022 17:18:26 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 6BF2C5C00D9; Thu, 22 Sep 2022 17:18:19 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 22 Sep 2022 17:18:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1663881499; x=1663967899; bh=dH QR8iDIvfMAP8IUVIzf8no7oLejlvwaHeO0xreMYtY=; b=NwVVci2OZsVN6sEZXG 3J5zSZ48HRiUrMLln8wvVm0WNspP6r61lB1+rV5YP4dsqJzs9G6j2VXciTlHQ81I pM/7u7DU6SdbTjIqOnReJPqHRQf0+AWXpxHoaSYWC6ghHhs0N5XFPU15eDQu2MZK aG+LmmXOFFD9NY9ukBLUSZLJ0SKdKjWgpO2Dfq65slw0o62SWbQOV+E8p9uBrXOP qLAGTHCJ8Z1fkdRmp7ideSWUU/yY2rwDY4tSoBCaqh0k/kH0pimyvj2Ty89PW0M5 g12TbIuIh3DxSC96gAS0SrPMIFScMbpWcS+CogLH8yPwOPxZKKBjNYIUtWxTdpU0 cMIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663881499; x=1663967899; bh=dHQR8iDIvfMAP8IUVIzf8no7oLej lvwaHeO0xreMYtY=; b=U6FSDFgnJDWEeCMHFUit4H3D/h34dFiUPoNj+wcN5i2d MapNF5guD41gGKdYwa4L/XYLlnyXAV8PTEYQt0l2lQXCD0W/283FwVwqYkB6DXKi kWyZw6RDRkve5LOlVleQMbWJ7lBZOu2a6S1eRAeyiOgyVDDtsm/4ztO7HwYWlVJr QnMjoLxUEEbZqG4dqKth91ek7DTWsNYkvnUZsaND9WHonGgKKzeMzBCGNUhSr8Ck bO1pLJyzmdQ2oOp1epzo/9wY33EST2rXmJAPSfLol6lVDREXpFce/QlF13Jmt7qY 0+Vst26q7yRbVa9yeuHl40AR3uNunUE6zUe6DgS3QQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefgedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Sep 2022 17:18:19 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 834677E8DE9; Thu, 22 Sep 2022 14:18:18 -0700 (MST) In-Reply-To: (Stefan Monnier's message of "Thu, 22 Sep 2022 12:55:10 -0400") Received-SPF: pass client-ip=66.111.4.28; envelope-from=spwhitton@spwhitton.name; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296009 Archived-At: Hello, On Thu 22 Sep 2022 at 12:55PM -04, Stefan Monnier wrote: >>> Robert Pluim [2022-09-22 11:25:31] wrote: >>>> Sean> +(defvar vc-want-edit-command-p nil >>>> Sean> + "If non-nil, let user edit the VC shell command before running it.") >>> >>> BTW, `-p` stands for "predicate", IOW *functions* that return booleans. >> >> I thought that in Lisp we often call boolean values predicates too, even >> though that violates the usage of 'predicate' in mathematics. >> >> Is there some other convention for booleans like this one? > > Usually we don't need it because the name says it, like > `vc-let-user-edit-commands`. I'd be happy to change it to this (minus the plural) if you and/or others would like. -- Sean Whitton