From: Andrea Monaco <andrea.monaco@autistici.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rms@gnu.org, rpluim@gmail.com, emacs-devel@gnu.org
Subject: Re: [PATCH v3] Allow applying filters to summary consecutively
Date: Fri, 28 Oct 2022 15:26:39 +0200 [thread overview]
Message-ID: <871qqshyeo.fsf@autistici.org> (raw)
In-Reply-To: <83y1t1l4tz.fsf@gnu.org> (message from Eli Zaretskii on Thu, 27 Oct 2022 17:27:20 +0300)
This version should be final. I change the name of the new
configuration item. It will also work as expected when generating a
filtered summary with no existing summary. Moreover, pressing q
(rmail-summary-quit) will kill the summary so the next filter starts
from scratch.
I add a function called rmail-summary--exists-1. The existing
rmail-summary-exists is not enough and I didn't know if changing it
could break something.
Andrea Monaco
Fix application of consecutive filters in rmail.
* lisp/mail/rmailsum.el (rmail-summary-intersect-consecutive-filters):
Change name.
(rmail-summary-currently-displayed-msgs):
Change to a bool-vector that is more natural.
(rmail-summary-populate-displayed-messages): Change name.
(rmail-summary--exists-1): New function.
(rmail-summary-by-labels, rmail-summary-by-recipients)
(rmail-summary-by-regexp, rmail-summary-by-topic)
(rmail-summary-by-senders): Fix so they work correctly when they are
invoked and no summary exists.
diff --git a/lisp/mail/rmailsum.el b/lisp/mail/rmailsum.el
index 0144a34e5e..b522449157 100644
--- a/lisp/mail/rmailsum.el
+++ b/lisp/mail/rmailsum.el
@@ -50,21 +50,18 @@ rmail-summary-line-count-flag
:type 'boolean
:group 'rmail-summary)
-(defcustom rmail-summary-apply-filters-consecutively nil
- "If non-nil, Rmail summary commands apply filtering on top existing filtering.
-When this variable is non-nil, `rmail-summary-by-*' commands work on the
-current summary, and so their filtering can be stacked one on top of another.
-This allows gradual narrowing of the selection of the messages."
+(defcustom rmail-summary-intersect-consecutive-filters nil
+ "Non-nil means that commands rmail-summary-by-* works on the
+current summary and so can be intersected one after the other."
:type 'boolean
:version "29.1"
:group 'rmail-summary)
(defvar rmail-summary-currently-displayed-msgs nil
- "String made of `y' and `n'.
-The character at position i tells wether message i is shown in the
-summary or not. First character is ignored.
-Used when applying `rmail-summary-by-*' commands consecutively. Filled
-by `rmail-summary-fill-displayed-messages'.")
+ "Boolean vector that for index i tells whether message i is
+shown on the summary or not. First element is ignored. Used
+when applying rmail-summary-by-* commands consecutively. Filled
+by rmail-summary-populate-displayed-messages.")
(put 'rmail-summary-currently-displayed-msgs 'permanent-local t)
(defvar rmail-summary-font-lock-keywords
@@ -284,33 +281,39 @@ rmail-summary-mode-map
(defun rmail-update-summary (&rest _)
(apply (car rmail-summary-redo) (cdr rmail-summary-redo)))
-(defun rmail-summary-fill-displayed-messages ()
- "Fill the rmail-summary-currently-displayed-msgs string."
+(defun rmail-summary-populate-displayed-messages ()
+ "Populate the rmail-summary-currently-displayed-msgs vector."
(with-current-buffer rmail-buffer
- (with-current-buffer rmail-summary-buffer
- (setq rmail-summary-currently-displayed-msgs
- (make-string (1+ rmail-total-messages) ?n))
- (goto-char (point-min))
- (while (not (eobp))
- (aset rmail-summary-currently-displayed-msgs
- (string-to-number (thing-at-point 'line))
- ?y)
- (forward-line 1)))))
+ (let ((totmsgs rmail-total-messages))
+ (with-current-buffer rmail-summary-buffer
+ (setq rmail-summary-currently-displayed-msgs
+ (make-bool-vector (1+ totmsgs) nil))
+ (goto-char (point-min))
+ (while (not (eobp))
+ (aset rmail-summary-currently-displayed-msgs
+ (string-to-number (thing-at-point 'line))
+ t)
+ (forward-line 1))))))
(defun rmail-summary-negate ()
- "Toggle display of messages that match the summary and those which do not."
+ "Negate the current summary. That is, show the messages that
+are not displayed, and vice versa."
(interactive)
- (rmail-summary-fill-displayed-messages)
+ (rmail-summary-populate-displayed-messages)
(rmail-new-summary "Negate"
'(rmail-summary-by-regexp ".*")
(lambda (msg)
(if
- (= (aref rmail-summary-currently-displayed-msgs msg)
- ?n)
- (progn
- (aset rmail-summary-currently-displayed-msgs msg ?y) t)
- (progn
- (aset rmail-summary-currently-displayed-msgs msg ?n) nil)))))
+ (eq (aref rmail-summary-currently-displayed-msgs msg)
+ nil)
+ (aset rmail-summary-currently-displayed-msgs msg t)
+ (aset rmail-summary-currently-displayed-msgs msg nil)))))
+
+(defun rmail-summary--exists-1 ()
+ "Like rmail-summary-exists, but works in both main and summary buffers."
+ (with-current-buffer rmail-buffer
+ (and rmail-summary-buffer (buffer-name rmail-summary-buffer)
+ rmail-summary-buffer)))
;;;###autoload
(defun rmail-summary ()
@@ -327,14 +330,16 @@ rmail-summary-by-labels
(setq labels (or rmail-last-multi-labels
(error "No label specified"))))
(setq rmail-last-multi-labels labels)
- (if rmail-summary-apply-filters-consecutively
- (rmail-summary-fill-displayed-messages))
+ (if (and rmail-summary-intersect-consecutive-filters
+ (rmail-summary--exists-1))
+ (rmail-summary-populate-displayed-messages))
(rmail-new-summary (concat "labels " labels)
(list 'rmail-summary-by-labels labels)
- (if rmail-summary-apply-filters-consecutively
+ (if (and rmail-summary-intersect-consecutive-filters
+ (rmail-summary--exists-1))
(lambda (msg l)
- (and (= (aref rmail-summary-currently-displayed-msgs msg)
- ?y)
+ (and (eq (aref rmail-summary-currently-displayed-msgs msg)
+ t)
(rmail-message-labels-p msg l)))
'rmail-message-labels-p)
(concat " \\("
@@ -349,15 +354,17 @@ rmail-summary-by-recipients
only look in the To and From fields.
RECIPIENTS is a regular expression."
(interactive "sRecipients to summarize by: \nP")
- (if rmail-summary-apply-filters-consecutively
- (rmail-summary-fill-displayed-messages))
+ (if (and rmail-summary-intersect-consecutive-filters
+ (rmail-summary--exists-1))
+ (rmail-summary-populate-displayed-messages))
(rmail-new-summary
(concat "recipients " recipients)
(list 'rmail-summary-by-recipients recipients primary-only)
- (if rmail-summary-apply-filters-consecutively
+ (if (and rmail-summary-intersect-consecutive-filters
+ (rmail-summary--exists-1))
(lambda (msg r &optional po)
- (and (= (aref rmail-summary-currently-displayed-msgs msg)
- ?y)
+ (and (eq (aref rmail-summary-currently-displayed-msgs msg)
+ t)
(rmail-message-recipients-p msg r po)))
'rmail-message-recipients-p)
recipients primary-only))
@@ -388,14 +395,16 @@ rmail-summary-by-regexp
(setq regexp (or rmail-last-regexp
(error "No regexp specified"))))
(setq rmail-last-regexp regexp)
- (if rmail-summary-apply-filters-consecutively
- (rmail-summary-fill-displayed-messages))
+ (if (and rmail-summary-intersect-consecutive-filters
+ (rmail-summary--exists-1))
+ (rmail-summary-populate-displayed-messages))
(rmail-new-summary (concat "regexp " regexp)
(list 'rmail-summary-by-regexp regexp)
- (if rmail-summary-apply-filters-consecutively
+ (if (and rmail-summary-intersect-consecutive-filters
+ (rmail-summary--exists-1))
(lambda (msg r)
- (and (= (aref rmail-summary-currently-displayed-msgs msg)
- ?y)
+ (and (eq (aref rmail-summary-currently-displayed-msgs msg)
+ t)
(rmail-message-regexp-p msg r)))
'rmail-message-regexp-p)
regexp))
@@ -443,15 +452,17 @@ rmail-summary-by-topic
(if subject ", default current subject" "")
"): ")))
(list (read-string prompt nil nil subject) current-prefix-arg)))
- (if rmail-summary-apply-filters-consecutively
- (rmail-summary-fill-displayed-messages))
+ (if (and rmail-summary-intersect-consecutive-filters
+ (rmail-summary--exists-1))
+ (rmail-summary-populate-displayed-messages))
(rmail-new-summary
(concat "about " subject)
(list 'rmail-summary-by-topic subject whole-message)
- (if rmail-summary-apply-filters-consecutively
+ (if (and rmail-summary-intersect-consecutive-filters
+ (rmail-summary--exists-1))
(lambda (msg s &optional wm)
- (and (= (aref rmail-summary-currently-displayed-msgs msg)
- ?y)
+ (and (eq (aref rmail-summary-currently-displayed-msgs msg)
+ t)
(rmail-message-subject-p msg s wm)))
'rmail-message-subject-p)
subject whole-message))
@@ -477,15 +488,17 @@ rmail-summary-by-senders
(if sender ", default this message's sender" "")
"): ")))
(list (read-string prompt nil nil sender))))
- (if rmail-summary-apply-filters-consecutively
- (rmail-summary-fill-displayed-messages))
+ (if (and rmail-summary-intersect-consecutive-filters
+ (rmail-summary--exists-1))
+ (rmail-summary-populate-displayed-messages))
(rmail-new-summary
(concat "senders " senders)
(list 'rmail-summary-by-senders senders)
- (if rmail-summary-apply-filters-consecutively
+ (if (and rmail-summary-intersect-consecutive-filters
+ (rmail-summary--exists-1))
(lambda (msg s)
- (and (= (aref rmail-summary-currently-displayed-msgs msg)
- ?y)
+ (and (eq (aref rmail-summary-currently-displayed-msgs msg)
+ t)
(rmail-message-senders-p msg s)))
'rmail-message-senders-p)
senders))
next prev parent reply other threads:[~2022-10-28 13:26 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 18:31 Summary by thread in rmail Andrea Monaco
2022-10-05 18:49 ` Eli Zaretskii
2022-10-05 23:40 ` Emanuel Berg
2022-10-06 22:04 ` Richard Stallman
2022-10-07 10:17 ` Andrea Monaco
2022-10-07 11:24 ` Emanuel Berg
2022-10-09 20:33 ` [PATCH] Allow applying filters to summary consecutively (was: Summary by thread in rmail) Andrea Monaco
2022-10-10 7:31 ` Eli Zaretskii
2022-10-10 8:38 ` Andrea Monaco
2022-10-10 8:57 ` Eli Zaretskii
2022-10-11 7:16 ` [PATCH v2] " Andrea Monaco
2022-10-11 8:13 ` [PATCH v2] Allow applying filters to summary consecutively Robert Pluim
2022-10-12 9:35 ` Andrea Monaco
2022-10-12 11:03 ` Robert Pluim
2022-10-12 12:56 ` Eli Zaretskii
2022-10-12 18:13 ` Andrea Monaco
2022-10-12 18:22 ` Eli Zaretskii
2022-10-12 22:02 ` Richard Stallman
2022-10-19 14:23 ` [PATCH v3] " Andrea Monaco
2022-10-19 14:55 ` Robert Pluim
2022-10-20 15:45 ` Andrea Monaco
2022-10-20 16:02 ` Robert Pluim
2022-10-20 19:00 ` Andrea Monaco
2022-10-21 19:42 ` Richard Stallman
2022-10-21 19:38 ` Richard Stallman
2022-10-27 14:27 ` Eli Zaretskii
2022-10-27 15:22 ` Andrea Monaco
2022-10-28 13:26 ` Andrea Monaco [this message]
2022-11-06 7:34 ` Eli Zaretskii
2022-11-07 14:13 ` Andrea Monaco
2022-11-08 5:02 ` Richard Stallman
2022-11-08 8:04 ` Andrea Monaco
2022-11-14 3:13 ` Richard Stallman
2022-11-10 4:04 ` Richard Stallman
2022-11-10 8:06 ` Eli Zaretskii
2022-11-10 8:53 ` Robert Pluim
2022-11-11 4:36 ` Richard Stallman
2022-11-11 8:06 ` Eli Zaretskii
2022-11-11 14:59 ` Juanma Barranquero
2022-11-11 17:23 ` Eli Zaretskii
2022-11-11 17:32 ` [External] : " Drew Adams
2022-11-11 18:00 ` Gregory Heytings
2022-11-11 18:19 ` Eli Zaretskii
2022-11-11 18:52 ` Gregory Heytings
2022-11-11 18:54 ` Gregory Heytings
2022-11-11 19:34 ` Eli Zaretskii
2022-11-11 19:33 ` Eli Zaretskii
2022-11-11 20:50 ` Gregory Heytings
2022-11-12 3:37 ` Richard Stallman
2022-11-12 7:52 ` Eli Zaretskii
2022-11-12 6:57 ` Eli Zaretskii
2022-11-12 16:30 ` Gregory Heytings
2022-11-12 17:44 ` Andrea Monaco
2022-11-12 18:13 ` Gregory Heytings
2022-11-14 3:13 ` Richard Stallman
2022-11-14 8:39 ` Gregory Heytings
2022-11-15 4:18 ` Richard Stallman
2022-11-15 9:56 ` Gregory Heytings
2022-11-16 3:15 ` Richard Stallman
2022-11-16 3:15 ` Richard Stallman
2022-11-24 18:25 ` Andrea Monaco
2022-11-28 21:38 ` Richard Stallman
2022-11-15 17:00 ` [External] : " Drew Adams
2022-11-14 3:13 ` Richard Stallman
2022-11-15 9:35 ` Gregory Heytings
2022-11-16 3:15 ` Richard Stallman
2022-11-19 14:47 ` Gregory Heytings
2022-11-20 17:37 ` Richard Stallman
2022-11-20 19:36 ` Gregory Heytings
2022-11-22 12:14 ` Richard Stallman
2022-11-22 12:58 ` Gregory Heytings
2022-11-28 21:38 ` Richard Stallman
2022-11-23 20:57 ` chad
2022-11-24 6:39 ` Eli Zaretskii
2022-11-28 21:38 ` Richard Stallman
2022-11-26 0:51 ` Richard Stallman
2022-11-11 18:22 ` [External] : " Drew Adams
2022-11-12 3:35 ` Richard Stallman
2022-11-12 7:47 ` Eli Zaretskii
2022-11-14 3:13 ` Richard Stallman
2022-11-17 13:34 ` Eli Zaretskii
2022-10-27 13:58 ` [PATCH v2] Allow applying filters to summary consecutively (was: Summary by thread in rmail) Eli Zaretskii
2022-10-10 22:03 ` [PATCH] " Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qqshyeo.fsf@autistici.org \
--to=andrea.monaco@autistici.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).