From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: feature/package-vc has been merged Date: Sat, 12 Nov 2022 07:59:25 +0000 Message-ID: <871qq81u3m.fsf@posteo.net> References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <87edupbdp0.fsf@posteo.net> <875yg1bc02.fsf@posteo.net> <878rkxgpms.fsf@posteo.net> <87sfiyk3a2.fsf_-_@posteo.net> <87mt948pmo.fsf@posteo.net> <87fsevyxnt.fsf@posteo.net> <87zgd1f70g.fsf@posteo.net> <878rkkbj90.fsf@posteo.net> <87edua7jw5.fsf@posteo.net> <878rki7jf3.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1707"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Richard Stallman , emacs-devel@gnu.org, 'Eli Zaretskii' To: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 12 09:00:18 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otlR4-0000FT-MN for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Nov 2022 09:00:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otlQM-0000Ge-Rs; Sat, 12 Nov 2022 02:59:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otlQK-0000DL-MF for emacs-devel@gnu.org; Sat, 12 Nov 2022 02:59:32 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otlQI-0000Iu-K9 for emacs-devel@gnu.org; Sat, 12 Nov 2022 02:59:32 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 999D3240027 for ; Sat, 12 Nov 2022 08:59:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668239968; bh=QMjpLFmDLkIBiweb/OJCU4OKP5SHpXiQyRsiGJBgv2I=; h=From:To:Cc:Subject:Date:From; b=WXbF73l/QWJkCpaUTXfywwM1520ydpYSlSFbJDx27kmI3ikA/9vPsPqUdeA+XT5sV 6i2dWUBKn4Qu7Xu1bPSjplRvbVl6mTjSaaPH9iKt9syHCfFwVmWTefNJEs/qKoMRUL wNsEV8IxHmVG6EBaplfYgZjEg7VJpl+zaRNOogKWTkCY6VrWRsPyY9GPYqHPhINV8B 3rD+rh6GQfZz3px4vVFcAHKwuYnsTFcHZDxQk54kVYqcAymMkIpmMWdl3g8jtCPzBl 4BKuev7JnrlhQJKooo1vLDNEMMxbXzEYhgmdBmnszZKBcenOhrH4jiWIL9al4DWefF cr7BpP2Xdp9uA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N8Sdn4CHtz9rxL; Sat, 12 Nov 2022 08:59:24 +0100 (CET) In-Reply-To: ("Rudolf =?utf-8?Q?Adamkovi=C4=8D=22'?= =?utf-8?Q?s?= message of "Sat, 12 Nov 2022 01:32:09 +0100") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299625 Archived-At: Rudolf Adamkovi=C4=8D writes: >> The documentation string tries to clarify what is does, but perhaps >> the name is confusing: >> >> "Refresh the installation for package given by PKG-DESC. >> Refreshing an installation means scraping for new autoload >> cookies, re-compiling Emacs Lisp files, building and installing >> any documentation, downloading any missing dependencies. This >> command does not fetch new revisions from a remote server. That >> is the responsibility of `package-vc-update'. Interactively, >> prompt for the name of the package to refresh." >> >> Reload? Regenerate? Redo? > > So good! The documentation before said that it refreshes the given > package. Hence, I kept scratching my head. Now, it all makes sense. > > As for the name, how about rebuild? All those steps normally happen > during a build process. I think "refresh" sounds much too close to > "update". That sounds good, I'll rename it to `package-vc-rebuild'. Thanks! >>> Oh, the list! Change the configuration again: >>> >>> (with-eval-after-load 'package-vc >>> (add-to-list 'package-vc-selected-packages '(modus-themes))) >>> >>> Restart Emacs. >> >> Two ways to resolve this: Either throw an error earlier, which might >> be annoying but the right thing=E2=84=A2, or dwim and accept that the va= lue >> might not be readable in ECI. > > Early or late, we need to show at least the traditional Emacs type > predicate error. I say that because it took me ten minutes to find the > problem. :) I am still confused as to how the error came about in the first place user-error: Unknown package to fetch: nil This means that `package-vc-install' was invoked with nil for NAME-OR-URL, right? I suspect that the condition in (unless (and name (package-installed-p name) (package-vc-p pkg-desc)) ...) =20=20 `package-vc-install-selected-packages' could be at fault here. I will think about it... >>> I could not find `package-vc-update-all' akin `package-update-all'. >>> Not that I needed it, but I looked for it in the case I manage to >>> install more packages. >> >> It doesn't exist. My idea was that package-update-all would handle >> that, but there might be a value in a command that only updates source >> packages? > > I think that would make sense. OK, I'll add it then. >>> The `package-vc-selected-packages' documentation [...] >> >> As mentioned above there are a few commits I haven't been able to push >> because emacs.git is preventing me from force pushing. I'll try to >> get them up there some other way, and then rewrite the history before >> rebasing the changes onto master. > > So much for "scratch" branches. :-/ I am not sure what you mean? The issue has since been resolved.