From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: Merging feature/android Date: Sun, 05 Mar 2023 11:16:20 +0800 Message-ID: <871qm3vqez.fsf@yahoo.com> References: <87edq7ztks.fsf.ref@yahoo.com> <87v8jjxxo9.fsf@yahoo.com> <835ybje2u5.fsf@gnu.org> <87fsanxoah.fsf@yahoo.com> <83zg8vckx5.fsf@gnu.org> <87bklay7wg.fsf@yahoo.com> <83ilficn4k.fsf@gnu.org> <87zg8uw9b9.fsf@yahoo.com> <837cvycjse.fsf@gnu.org> <87ttz2w4c3.fsf@yahoo.com> <83356mcbxw.fsf@gnu.org> <87pm9qvu9w.fsf@yahoo.com> <83y1odc37g.fsf@gnu.org> <87cz5pwf9c.fsf@yahoo.com> <83edq5asb3.fsf@gnu.org> <875ybhvt4w.fsf@yahoo.com> <83356kbxnh.fsf@gnu.org> <87lekcvho4.fsf@yahoo.com> <83r0u4adgd.fsf@gnu.org> <87a60suknn.fsf@yahoo.com> <563e9da9-c45e-a4d2-6dda-074ac035c256@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14289"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 05 04:17:20 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYesB-0003V0-Gm for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Mar 2023 04:17:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYerZ-0005Te-5H; Sat, 04 Mar 2023 22:16:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYerR-0005TH-7q for emacs-devel@gnu.org; Sat, 04 Mar 2023 22:16:38 -0500 Original-Received: from sonic316-21.consmr.mail.ne1.yahoo.com ([66.163.187.147]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYerP-000820-11 for emacs-devel@gnu.org; Sat, 04 Mar 2023 22:16:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677986187; bh=Dw1TpGrCPRE3g1IEvCC2gHvOFnkeEGyCY7HX3LLTLE8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=bCzFsx0Kc3aCUW7zTIC5995RhchyyQArwL95YscZ370CueaIi1R640biR5tx9H81CudBCAZ8bcVTpNuMFChC9qe8++i6GrVnLnsyw5vTyd5NwB5gAORtyEZLEL3I9x3mt//TOYgVbNK0HN/rC/nbrJpfJ3pzpr7TSch7K3abVY0l0QRoSr87k+o7bk3RHmptfWkFUXI1QxfrBZkzveCwi5A3hXCf+JTLMHZFAhf0PNPX4SLkICFX0oIztPh6qivXTeIMoY6oyeQwZUpTA8S0Qvi/FdFyL3fMjXHleHOCnOp+fY7Qq5ihguvJcpyfoviyjpPFWALbgNjWYJogDNwaag== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677986187; bh=v7rZ4EdhzvqKenfKhs4vYHGDqi296IH0vbiprOZVxn2=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=PF0r5CcB5yEJOHBmusSV47kzO9FMLgrOiV0x4t83BYbwwtA6yToIrcozol6bV9VxbUu/pjXcgTZwM3V/Cr/MxwR4+ZPXwG+dnwKVT1AJ986fwKwrv2JgQjoGcGrNypt8N8teU4BFYBhCLuxF9s/8y1lctkYjY4e4uMIehprQ02RAahFoKcGasol+EuSw/hM2YcNpZhop/FwlrxIWskSTB1yYaWloWFN7flctrU5UP/7jx3YbzHPcY7Ds70Q/TWiUG5DNSPp1YmSYVnvI6Nu8wwz1o7jcWExauWp3Eng15B6qLHgnHHNTtFNocAUHgFylsmAAphhHGdBK5TijNfUpWA== X-YMail-OSG: zgaEqOIVM1m5bOGvanBsUZW0Lh9BPjAwoRTFt0WMt9ethzUYoHcItREI5CxoYHq XtEOpmUH7wstcdnm91D530z83ssCYzv.fFKz1NjzZ1keranuVXtQZsWl3QiHy.mSZPHxm6qzblgv QvUGD.voFZNAusu8ctq4B4y3.Le..9C5DvJJn9sBulT.z9ktYycDHWooUGcOlJplkM.5ZRWIx3Wb bsVse1E0QryaIdEfifgxDysH6uo0GxX_a07qBDnVIfVfi2.HwA40GjUXXpV3Bqt3JQ79TK_bSjek f6nV2ZY.Yja_9dCwBuPCexqgKYLMUhUKpu8OvdKjpFC1lVSFjkV90ntW9U06a.P59lLa54bzReo3 l6oX6P0o2.ExTqKdx7GzzaTS4Hnuk4lGbQ8vHkblMZ7_a8_87nhKZw9YK0F5p2Bm.CRYgrrv4QFb XxiwfKLuLkeennlW14EPErQ8H8Jm8Kt4ZVbrVZtLu8dPLAlT7M6lQCa2dck8WxSxw2SwR9hUnmf9 KXcHatcuz6Dagt0xQ8TJesZxgcTCU6hWEqd3VoUpzc6qrDHx94f3BvbKvHj_etyGD60UHI2cxX.d dSLBfDEWv3KiBP6EOHx6VQJW1kpvBVNp9SywYaTdAGU1VIbwAFMomdpRFPryKypTJKfRhCv_.ISB uR9LhrpQ74gb027t4xEmm2_.90Tlil35LogC0iwGoTIbi4zv5s9AmbZDo8SFD5dIYWIZUa963oep thFeo1jh4PWo6uFA9fStiPOMGZ5zJ6MOwXJvM5CBZrmbHFALe1BIloSCH5HdOKz11PCt2CcSBneH cfVEOsAXdaMrV.5NgN.VFjjkJdBtTf0DDlUlvmuWsv X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Sun, 5 Mar 2023 03:16:27 +0000 Original-Received: by hermes--production-sg3-67c57bccff-zjnsf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID de42d05bd42bf0bbb07a0862e1737136; Sun, 05 Mar 2023 03:16:24 +0000 (UTC) In-Reply-To: <563e9da9-c45e-a4d2-6dda-074ac035c256@cs.ucla.edu> (Paul Eggert's message of "Sat, 4 Mar 2023 18:17:56 -0800") X-Mailer: WebService/1.1.21221 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.187.147; envelope-from=luangruo@yahoo.com; helo=sonic316-21.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303954 Archived-At: Paul Eggert writes: > Actually dynamic module support should build with Sun C 5.15 (i.e., > Oracle Solaris Studio 12.6), because Sun C supports GNU C's > __attribute__ ((cleanup)) extension. I think icc also supports that > extension. Not that I've ever used modules on those platforms. Well, I do recall /opt/SUNwspro/bin/cc choking on emacs-module.c at some point in the past. I didn't think much of it at the time and just gave: ./configure CC=gcc7 but that's not something we want to make everyone do. In retrospect, it probably failed because the ifdefs in emacs-module.c did not detect the attribute support correctly. > As I vaguely recall, this issue came up in 2015 when Emacs modules > were added, and it was decided that there wasn't a practical way to > get Emacs modules to work if the compiler did not support a cleanup > attribute of some sort. Right, so the correct solution is to check whether or not the compiler supports such an extension, and disable dynamic module support should it not. Which is why we use configure in the first place, instead of performing ``checks'' with `GNUC_PREREQ'. > I'm a bit surprised that the Android NDK doesn't support the > attribute, though, as I thought it was based on Clang. Perhaps there's > an alternate compiler you can use to build on Android. The attribute leads to a compiler error generating while generating debug information, or alternatively the #error "__attribute__ ((cleanup)) not supported by this compiler; try GCC" in emacs-module.c being triggered, depending on the version of the NDK you use. r21 and r25 are free of this illness, but they don't support old versions of Android that Emacs does, such as Android 4.4 or 2.2. (And the other day someone asked me for a build of Emacs that runs on Android 4.1, so these versions are evidently being used.)