From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 0724c6dbdae: Use string-search instead of string-match[-p] when possible Date: Wed, 29 Mar 2023 17:54:04 +0200 Message-ID: <871ql7mu3n.fsf@gmail.com> References: <167982767456.13549.3313290435008922358@vcs2.savannah.gnu.org> <20230326104755.356B1C1391D@vcs2.savannah.gnu.org> <875yajmvjc.fsf@gmail.com> <8C045DB0-F4B5-4469-8BA6-F838F6DBE755@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20398"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 29 17:54:38 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phY8B-0004zR-HK for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Mar 2023 17:54:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phY7q-0007Tz-NF; Wed, 29 Mar 2023 11:54:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phY7o-0007Th-0s for emacs-devel@gnu.org; Wed, 29 Mar 2023 11:54:12 -0400 Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1phY7l-0004Dj-Fr for emacs-devel@gnu.org; Wed, 29 Mar 2023 11:54:11 -0400 Original-Received: by mail-wr1-x431.google.com with SMTP id r11so16247510wrr.12 for ; Wed, 29 Mar 2023 08:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680105247; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=hoTVP6T5wSI/ak4Wvkc3L/vvNcQLY1lESmLhGGBjsms=; b=QxJQTndVongVjALXbsD2fwiJ5pzr3RG0RcXUHMHlIiMixejzbc7OUyaPcv/QgfHpOa eh814207sYeGbxKGgpnSctFgGZuKwce6WA9rz6EMpDrmzZ+4o/PVtjjv+EHcyfSVPRr+ BQNYmeSnRj/oB0A+pPYdE1TI/QIWz+TRsj/t8WA1ea9zXs4ZT8F7IDfFgUbNfVvX3/wx NwJNohNRNk/M22Dq2L4TFdUziIaDLisIwbgkl+HU4RLB0ZChp+Ln8ydhil/6SJt8UCzO IHjxi++QuiiO94BoZIeaR/1K3hTFzVuK64/fRlG4xZnafiDIVYwbojg5hK04hHsiMCIV /A1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680105247; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hoTVP6T5wSI/ak4Wvkc3L/vvNcQLY1lESmLhGGBjsms=; b=E1qUA+6XacyCRGibpmuzSl34PyL2TLDGiopH04c1OS1G+p7NOFQpmv7TaUPdtOMULT OhwC6Y4LzMjUIrFcCu38+HFXeOzcxB+4r1s8UCVvYuYVoHGPaWyPMVMkogZWOuPDG2s0 uwp+P2F4jLru7TdLAFX2gHAFbAR32vmgrOTbQB+J5Rml5G5QicZsR6YLDgTpfjf7yB8C 0e3kEOc91fDWRxlPLVT2z42hKePrDGT2S9Z8RUk8B9erFJKQXMa2YpPe2bwemdrZn7vP AwG7k0bSqGWipdg9GWspNq4tFGHpx2KJx3p2HDNvfwxDYxlaMrn8S7nEixJF3eSIOtgZ oC5A== X-Gm-Message-State: AAQBX9djfLJmC+XSebStF9UGvEXAB9Y/OgGxTg4Ida+BABscdEg0LFoz YKUgZpI7dR3gynLblr5A1FFurpvssOk= X-Google-Smtp-Source: AKy350aFm6QkuNMqRuk/CBrQbQZiZyVK3b/G4qhbu5tjnjGYSYBerDxm/laVXBuiHEIPJQ7Kt76AMg== X-Received: by 2002:a5d:4f0c:0:b0:2c5:4ffb:b5d4 with SMTP id c12-20020a5d4f0c000000b002c54ffbb5d4mr2377351wru.19.1680105247126; Wed, 29 Mar 2023 08:54:07 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id n12-20020adfe34c000000b002da75c5e143sm18138207wrj.29.2023.03.29.08.54.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Mar 2023 08:54:06 -0700 (PDT) In-Reply-To: <8C045DB0-F4B5-4469-8BA6-F838F6DBE755@acm.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Wed, 29 Mar 2023 17:34:36 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=rpluim@gmail.com; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304824 Archived-At: >>>>> On Wed, 29 Mar 2023 17:34:36 +0200, Mattias Engdeg=C3=A5rd said: Mattias> 29 mars 2023 kl. 17.23 skrev Robert Pluim : >> Hmm, we could do this using a compiler macro, no? Something like >>=20 >> (put 'string-match-p 'compiler-macro >> #'byte-optimize-string-match-p) Mattias> No, that would be incorrect: string-match-p obeys case-fold-se= arch, string-search doesn't. Right, I=CA=BCd forgotten about that. And a warning would be a bit intrusive, I think. Mattias> Replacing string-match[-p] with string-search in the source al= so makes the code clearer. That=CA=BCs definitely true. Robert --=20