From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: john muhl Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: lua-ts-mode Date: Thu, 27 Jul 2023 16:52:47 -0500 Message-ID: <871qgscewi.fsf@pub.pink> References: <87o7jyd3bs.fsf@pub.pink> <831qgunew3.fsf@gnu.org> <87fs59nwef.fsf@pub.pink> <83cz0dkwd6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26639"; mail-complaints-to="usenet@ciao.gmane.io" Cc: theo@thornhill.no, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 28 16:25:51 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPOPe-0006jk-ST for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Jul 2023 16:25:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qPOHV-0008Ld-1K; Fri, 28 Jul 2023 10:17:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPO3a-0001Dz-RV for emacs-devel@gnu.org; Fri, 28 Jul 2023 10:03:03 -0400 Original-Received: from out-120.mta0.migadu.com ([2001:41d0:1004:224b::78]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPO3Z-0003gD-1m for emacs-devel@gnu.org; Fri, 28 Jul 2023 10:03:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; s=key1; t=1690552976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hNUg3EM82aKlHYTpB9G+3ErsaZEeyvcnkDqyFEKTwAU=; b=iOau3TLqUDYqgUDNAU66MO+I5u/BbtO/NNXa0Vz+zTHzzIrKi+MpRQ+DWo+uWVXTo2Lp6C BlVNIKNokQ7C95VDVdsmxgnMn6EnfaM+BvBehbpjQyQxYiJfHpC9Qe/3WGM9TJFh+B4UAk JB8u8hSZzySkpU+vvw+Nm1oGEIBkcoo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <83cz0dkwd6.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::78; envelope-from=jm@pub.pink; helo=out-120.mta0.migadu.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_12_24=1.049, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 28 Jul 2023 10:17:17 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308191 Archived-At: Eli Zaretskii writes: > It isn't a prerequisite, no. It just would be nice to be able to > support both. Fair enough. I gave it a closer look and don=E2=80=99t think it=E2=80=99s p= ossible to support even on its own. Try opening a file containing: print(1) Enable treesit-explore-mode and see: (call function: (variable name: (identifier)) arguments: (ERROR ( (number) )) ; That ERROR node is erroneous (argument_list (string))) Those stray ERRORs are pervasive and all kinds of code end up with them in unexpected places. There may be other issues but this one is enough to make it unusable. I don=E2=80=99t think this is fixable on the Emacs sid= e. Another problem is that in an empty buffer Emacs freezes when you start typing. The Azganoth grammar and t-e-m must be enabled for it to freeze. This might be fixable in Emacs but wouldn=E2=80=99t change the problem with misplaced ERROR nodes. If someone fixes the problems with the grammar or shows where I=E2=80=99ve = gone wrong I=E2=80=99m happy to revisit.