From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Proposal for 'package-isolate' command Date: Sun, 20 Aug 2023 18:41:08 +0000 Message-ID: <871qfxtv3v.fsf@posteo.net> References: <87r0oftgye.fsf@posteo.net> <87350vt1wz.fsf@posteo.net> <871qgen1ln.fsf@posteo.net> <87edke4mou.fsf@posteo.net> <87wmy6kuan.fsf@posteo.net> <87wmy6w070.fsf@posteo.net> <87zg2sjleg.fsf@posteo.net> <87pm3nlbm7.fsf@posteo.net> <87zg2ri9g9.fsf@posteo.net> <87bkf7b7ls.fsf@posteo.net> <87v8dfi6zy.fsf@posteo.net> <877cpvb361.fsf@posteo.net> <87pm3mj0ot.fsf_-_@posteo.net> <87v8de9qel.fsf@posteo.net> <87pm3mgj8d.fsf@posteo.net> <877cpq9p7s.fsf@posteo.net> <878ra5d70p.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32008"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 20 20:42:13 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXnNK-00084B-UQ for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Aug 2023 20:42:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXnMS-0003Ii-Pl; Sun, 20 Aug 2023 14:41:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXnMS-0003Ia-1f for emacs-devel@gnu.org; Sun, 20 Aug 2023 14:41:16 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXnMP-0000Zv-Cs for emacs-devel@gnu.org; Sun, 20 Aug 2023 14:41:15 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5EFBA240103 for ; Sun, 20 Aug 2023 20:41:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692556870; bh=zWeP+WLoUZ53NpryRWwzhrvNHjYVKlOfH8vqwVQ1xMA=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=pZI96haR+yDNSeXksU9mtnegsZAyaHCaCqLtQXNL4/xyj/6Vh/FYKeloDZnJQbMaq 9Zp7hWbHkeF8diMFgyCj2HbYwFlnGNZDhBUADNf0OMFhhUVyeSKo/1PL91VW25QqUR W7Jxx7D4ZJmw+z60S5S8aGdaPpj6OZkf51lijROW0Ga3KeCpgmKgI+snx8wiob+krV iZm85iTY0RgbdsJwOOlO5SmL7MawngPhJMHguaXf71SRwB5hgMHMhG8Jabmd7BS2Tz oozOONMsuiyT0KVbBMHJMpTNjn35rM4iyr0FygKXVcZyw1e8Pp6HuvsjrROdrDxkhh 1OS7uKYSn8IsQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RTPZY6rnsz6trs; Sun, 20 Aug 2023 20:41:09 +0200 (CEST) In-Reply-To: <878ra5d70p.fsf@posteo.net> (Thierry Volpiatto's message of "Sun, 20 Aug 2023 16:06:46 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308981 Archived-At: Thierry Volpiatto writes: > Thierry Volpiatto writes: > >> Hello Philip, >> >> Philip Kaludercic writes: >> >>> How about this patch, that will use a temporary directory when >>> `package-isolate' is invoked with a prefix argument (not sure what the >>> default should be, I guess reusing `user-emacs-directory' is less >>> surprising): >>> >>> [2. text/x-diff; 0001-Add-command-to-start-Emacs-with-specific-packages.patch]... >> >> I was reading the code of the new version of `package--dependencies` and >> had some questions: >> >> --8<---------------cut here---------------start------------->8--- >> (named-let more ((pkg-desc desc)) >> (let (deps) >> (dolist (req (package-desc-reqs pkg-desc)) >> (setq deps (nconc >> (catch 'found >> (dolist (p (apply #'append (mapcar #'cdr (package--alist)))) >> (when (and (string= (car req) (package-desc-name p)) >> (version-list-<= (cadr req) (package-desc-version p))) >> (throw 'found (more p))))) >> deps))) >> (delete-dups (cons pkg-desc deps)))) >> --8<---------------cut here---------------end--------------->8--- >> >> Why are you using `string=` to compare (car req) >> with (package-desc-name p)? >> >> Isn't (apply #'append (mapcar #'cdr (package--alist))) same as >> (mapcar #'cadr (package--alist))? >> >> I am not a fan of named-let but isn't using deps as a second arg of >> 'more' more in the named-let spirit? (fully not tested) >> >> --8<---------------cut here---------------start------------->8--- >> (named-let more ((pkg-desc desc) >> (deps nil)) >> (dolist (req (package-desc-reqs pkg-desc)) >> (setq deps (nconc >> (catch 'found >> (dolist (p (apply #'append (mapcar #'cdr (package--alist)))) >> (when (and (string= (car req) (package-desc-name p)) >> (version-list-<= (cadr req) (package-desc-version p))) >> (throw 'found (more p deps))))) >> deps))) >> (delete-dups (cons pkg-desc deps))) >> --8<---------------cut here---------------end--------------->8--- > > After some tests this create circular lists, so forget it. I guess you could avoid that by replacing 'nconc' with 'append'. > Also now from Emacs 29 (magit is NOT installed): > > (package-initialize) > (package--dependencies 'magit) > => (emacs compat dash git-commit magit-section seq transient with-editor) > > Now if I eval your new package--dependencies from Emacs 30: > (package-initialize) > (package--dependencies 'magit) > => (compat) > > What is wrong is you are looping in package-alist instead of > package-archive-contents, in fact you don't need to loop at all, just > using assq or package-get-descriptor: > > (defun package--dependencies (pkg) > "Return a list of all transitive dependencies of PKG. > If PKG is a package descriptor, the return value is a list of > package descriptors. If PKG is a symbol designating a package, > the return value is a list of symbols designating packages." > (when-let* ((desc (if (package-desc-p pkg) pkg > (cadr (assq pkg package-archive-contents))))) > ;; Can we have circular dependencies? Assume "nope". > (let ((all (cl-labels ((more (pkg-desc) > (let (deps) > (dolist (req (package-desc-reqs pkg-desc)) > (setq deps (nconc > (when-let* ((matched (package-get-descriptor (car req))) > (version<= (version-list-<= > (cadr req) > (package-desc-version matched)))) An issue I see here, is that a required version might not be satisfied by the version of the package returned by `package-get-descriptor'. Or am I mistaken? > (more matched)) > deps))) > (delete-dups (cons pkg-desc deps))))) > (more desc)))) > (remq pkg (mapcar (if (package-desc-p pkg) #'identity #'package-desc-name) all))))) > > PS: Sorry I used cl-labels to test as I am not easy with named-let. "Not easy" in the sense that you are not familiar with how it works, or thin k it shouldn't be used? All in all, `named-let' just compiles down to a cl-labels call, similar to the one you propose.