From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: package-vc support for :files keyword Date: Mon, 18 Sep 2023 15:52:37 +0000 Message-ID: <871qevbhru.fsf@posteo.net> References: <87ttrshrib.fsf@hyperspace> <871qev6e53.fsf@posteo.net> <87r0mviltd.fsf@hyperspace> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25836"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Tony Zorman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 18 17:53:33 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiGZ2-0006UU-Ay for ged-emacs-devel@m.gmane-mx.org; Mon, 18 Sep 2023 17:53:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiGYI-0005rv-4j; Mon, 18 Sep 2023 11:52:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiGYG-0005re-6i for emacs-devel@gnu.org; Mon, 18 Sep 2023 11:52:44 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiGYD-0001b1-RC for emacs-devel@gnu.org; Mon, 18 Sep 2023 11:52:43 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 65862240101 for ; Mon, 18 Sep 2023 17:52:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1695052358; bh=M+5UTmu9DbI5qZIoM2RwaaPWHMo/EERsYMHAV0wA+3E=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=kvBkO7yv2eWZNjjLv3Ruk+3B6gPFY6Z7KSMCYqryX1wsoZyNAcLzzw+kcLkQT6WS5 RhJsZDuQ/gJMAhABADc+uNsIwp4lx382mq30sz5pOO2UFTaNj0SOPD4RUplcIKRFMh 9JpbieqDAGMC3J2UsSZsLqR4e120M3vEN5HXUpb/jUnIDi0fFOLI0ZJX3OkWnxUncs gDxDrLsWCAo6O9CP/3b+CjeRYcvANRMGZcHKl0aUtBFmjO7lriwLtapPJXf+WOiuUR sXz4j4DKbxnmqVfq0yEABjkNoLNnTRQZ6XJvWtrUojN+FbFYL78xrNUSgOAcvapu/J s8NYyCxfkZSbA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Rq8Sj6w64z6twM; Mon, 18 Sep 2023 17:52:37 +0200 (CEST) In-Reply-To: <87r0mviltd.fsf@hyperspace> (Tony Zorman's message of "Mon, 18 Sep 2023 16:43:26 +0200") X-Hashcash: 1:20:230918:emacs-devel@gnu.org::niLdRstEVcQuBegz:8lJL X-Hashcash: 1:20:230918:tonyzorman@mailbox.org::di+deYbzEcEP5xRV:A3Lf Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310706 Archived-At: Tony Zorman writes: > On Mon, Sep 18 2023 09:10, Philip Kaludercic wrote: >> Tony Zorman writes: >>> here's an idea: why not create e.g. a variable to decide when >>> :shell-command is executed? Moving the execution to right after cloning >>> the repository, instead of before building documentation, would enable >>> one to easily emulate :files directives, as well as other keywords that >>> need to be executed before things actually get built. >>> >>> Alternatively one could have a second :shell-command like keyword. >> >> My issue with the first idea would be that this would create a greater >> discrepancy between what elpa-admin and package-vc do. So if anything, >> I think only the second option, e.g. :early-shell-command, would be >> viable. > > Fair enough. > >> In both cases, what would you imagine that the command would do? If it >> just calls "rm foo.el bar.el ...", then we have an issue when upgrading, >> because there would at least be a merge conflict any time the other >> files are modified upstream. Upgrading isn't easy the way it is, but >> raising the necessity for manual intervention every time is something >> I'd like to avoid. > > I think that > > $ rm foo.el > $ git update-index --assume-unchanged foo.el > > should work. It should merge cleanly (I've tried this out just now, and > it worked, but I may have overlooked something). If it's part of the > package description, then updating should work out of the box, since > package-vc-upgrade also calls package-vc--unpack-1, which would execute > the respective :early-shell-command again. Being a git-specific command, this shouldn't be added to package-vc directly. If there is a VCS agnostic/generalisable way of doing this, then it could be added to VC. But for now, if I understand you correctly, you are suggesting that users give package specifications like this: (foo :url "https://some.vcs/repository" ;; ... :early-shell-command "rm [all the files]; git update-index --assume-unchanged [all the files]") where [all the files] might change between updates. At this point I continue to question the utility of emulating MELPA-style :files attributes, unless there are concrete usability issues. For the record, these are all the repositories in {Non,}GNU ELPA that develop multiple packages in a single repository: GNU ELPA: http://www.dr-qubit.org/git/predictive.git https://github.com/oantolin/embark https://github.com/abo-abo/swiper https://github.com/abo-abo/hydra https://github.com/alphapapa/taxy.el.git NonGNU ELPA: https://github.com/lewang/flx https://github.com/emacs-helm/helm https://github.com/magit/magit https://github.com/brianc/jade-mode >From what I understand, there is no technical necessity for this mode of development? I wonder how difficult it would be to push for a one-package-one-repo approach. >> Also, what would a :early-shell-command be used for >> on the ELPA build server? > > That I don't know, I've never consciously looked at the ELPA build > server. -- Philip Kaludercic