From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: package-vc support for :files keyword Date: Mon, 18 Sep 2023 09:10:00 +0000 Message-ID: <871qev6e53.fsf@posteo.net> References: <87ttrshrib.fsf@hyperspace> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16988"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Tony Zorman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 18 11:11:08 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiAHa-0004Hd-TU for ged-emacs-devel@m.gmane-mx.org; Mon, 18 Sep 2023 11:11:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiAGf-0006TX-7R; Mon, 18 Sep 2023 05:10:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiAGd-0006TA-Tt for emacs-devel@gnu.org; Mon, 18 Sep 2023 05:10:08 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiAGb-0002YE-M1 for emacs-devel@gnu.org; Mon, 18 Sep 2023 05:10:07 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id BEC9824002D for ; Mon, 18 Sep 2023 11:10:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1695028200; bh=lbw8V0LtgL503dZthe/GH9+JOsyOOoPUggmKv2mb+rY=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=TwJJAOgTiWSHF7WaGqg2QATs9inq7rloZQkHTrB155R4r86VYycD5kqF9Hv543vn1 Rn3700R+OvUs4rT7uRhTN0uZTKcaS+w0opbkf8ckRaw9Vm0sQTPN2Z43U9gxP9Fv36 7WkX3kqbraAWHtfwY1kae3memneV+K7cE2CoF9ocMf3HgbHMpP6nwhTzPnm05nTejj x9CAF4TWHK/pQEdS34mr+2IpUs7j5xAhH5ZotPLwyad5cyNBsUkhw0K9hJSLH+4k+o q2Gbqz2JP4a+rM0Cpp8qBLrKQw2uTtnZ8s2nSkTgoC2+zz5K1k0fezU0ccYXIuedGm 7PWnBhUCNE1BA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RpzX83FNvz6tn4; Mon, 18 Sep 2023 11:10:00 +0200 (CEST) In-Reply-To: <87ttrshrib.fsf@hyperspace> (Tony Zorman's message of "Mon, 18 Sep 2023 09:25:48 +0200") X-Hashcash: 1:20:230918:emacs-devel@gnu.org::Hyg7pjITn9ke2XNB:VsD X-Hashcash: 1:20:230918:tonyzorman@mailbox.org::2XwSbjYmUdbu55wy:06Bc Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310687 Archived-At: Tony Zorman writes: > Hi, > > Philip Kaludercic writes: >> But just like :make and :shell-command, or use-package support was not >> intended in the beginning, I don't insist on anything as long as a >> good compromise can be found. I just have my doubts, since supporting >> this would probably run against a number of basic assumptions that >> package-vc was written around. > > here's an idea: why not create e.g. a variable to decide when > :shell-command is executed? Moving the execution to right after cloning > the repository, instead of before building documentation, would enable > one to easily emulate :files directives, as well as other keywords that > need to be executed before things actually get built. > > Alternatively one could have a second :shell-command like keyword. My issue with the first idea would be that this would create a greater discrepancy between what elpa-admin and package-vc do. So if anything, I think only the second option, e.g. :early-shell-command, would be viable. In both cases, what would you imagine that the command would do? If it just calls "rm foo.el bar.el ...", then we have an issue when upgrading, because there would at least be a merge conflict any time the other files are modified upstream. Upgrading isn't easy the way it is, but raising the necessity for manual intervention every time is something I'd like to avoid. Also, what would a :early-shell-command be used for on the ELPA build server? > Tony -- Philip Kaludercic