unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Kyle Meyer <kyle@kyleam.com>, emacs-devel@gnu.org
Subject: Re: master 5a125fb5a97 1/2: Update to Org 9.7.3
Date: Tue, 11 Jun 2024 10:05:01 +0000	[thread overview]
Message-ID: <871q53u75e.fsf@localhost> (raw)
In-Reply-To: <868qzd9hjg.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

> There are other issues with this update:
>
>     ELC      org/org-macs.elc
>
>   In end of data:
>   org/org-loaddefs.el:1278:78: Warning: the function `cl-every' is not known to be defined.
>
> Can this warning be eliminated, please?

It can be eliminated, but the warning does not seem to be Org mode's
fault.

The line in question in org-loaddefs is

(custom-autoload 'org-num-skip-tags "org-num" t)
(put 'org-num-skip-tags 'safe-local-variable (lambda (val) (and (listp val) (cl-every #'stringp val))))

It is not generated by Org mode, but by loaddefs.el from

(defcustom org-num-skip-tags nil
  "List of tags preventing the numbering of sub-trees.

For example, add \"ARCHIVE\" to this list to avoid numbering
archived sub-trees.

Tag in this list prevent numbering the whole sub-tree,
irrespective to `org-use-tag-inheritance', or other means to
control tag inheritance."
  :group 'org-appearance
  :package-version '(Org . "9.3")
  :type '(repeat (string :tag "Tag"))
  :safe (lambda (val) (and (listp val) (cl-every #'stringp val))))

Note that org-num.el where `org-num-skip-tags' is defined does have
(require 'cl-lib).

IMHO, there is some problem either with loaddefs generation or with the
fact that loaddefs file is compiled at all.

Of course, we can always convert that lambda into a proper function,
which will likely get rid of the warning. (btw, the warning does not
appear when running make bootstrap on my side)

>   Could not read `org-id-locations' from ~/.emacs.d/.org-id-locations, setting it to nil
>
> Why does it want to read a file from my home directory as part of
> building Emacs?  That shouldn't happen.

Agree. But I am unable to reproduce.
Could you please provide more information?

>   Executing Emacs-Lisp code block at position 643527...
>   Code block evaluation complete.
>   Executing Emacs-Lisp code block at position 646480...
>   Code block evaluation complete.
>   Executing Emacs-Lisp code block at position 648303...
>   Code block evaluation complete.
>   Executing Emacs-Lisp code block at position 648968...
>   Code block evaluation complete.
>   Executing Emacs-Lisp code block at position 655333...
>   Code block evaluation complete.
>   Executing Emacs-Lisp code block at position 659159...
>   Code block evaluation complete.
>   Executing Emacs-Lisp code block at position 659467...
>   Code block evaluation complete.
>   Executing Emacs-Lisp code block at position 660552...
>   Code block evaluation complete.
>
> Can we please shut up these messages, or at least hide them behind
> some $(AM_V_GEN) trick?

Why? It is not much different from "scraping loaddefs..." message
sequence.

Of course, we can hide this, but seeing that some code is evaluated may
be useful in the logs.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



  reply	other threads:[~2024-06-11 10:05 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171796793548.23337.12512115872160390161@vcs2.savannah.gnu.org>
     [not found] ` <20240609211858.A2C31C1F9FB@vcs2.savannah.gnu.org>
2024-06-10  0:40   ` master 5a125fb5a97 1/2: Update to Org 9.7.3 Po Lu
2024-06-10  1:14     ` Kyle Meyer
2024-06-10  3:45       ` Po Lu
2024-06-10  3:58         ` Po Lu
2024-06-12 13:08         ` Ihor Radchenko
2024-06-12 13:13           ` Eli Zaretskii
2024-06-12 13:23             ` Ihor Radchenko
2024-06-12 13:30               ` Eli Zaretskii
2024-06-14 13:18                 ` Ihor Radchenko
2024-06-10 11:13       ` Eli Zaretskii
2024-06-11 10:05         ` Ihor Radchenko [this message]
2024-06-11 12:23           ` Eli Zaretskii
2024-06-11 13:10             ` Robert Pluim
2024-06-14  9:49               ` Ihor Radchenko
2024-06-14 11:39                 ` Eli Zaretskii
2024-06-14 12:02                   ` Robert Pluim
2024-06-11 13:16             ` Stefan Monnier
2024-06-12 13:49               ` Ihor Radchenko
2024-06-12 14:41                 ` Stefan Monnier
2024-06-13 13:00             ` Ihor Radchenko
2024-06-13 13:43               ` Eli Zaretskii
2024-06-13 14:34                 ` Stefan Monnier
2024-06-14 12:39                 ` Ihor Radchenko
2024-06-13 13:32             ` Ihor Radchenko
2024-06-13 13:54               ` Eli Zaretskii
2024-06-15 11:20                 ` Ihor Radchenko
2024-06-15 12:46                   ` Eli Zaretskii
2024-06-15 12:55                     ` Syncing Org bugfix releases with emacs-30 branch (was: master 5a125fb5a97 1/2: Update to Org 9.7.3) Ihor Radchenko
2024-06-15 13:02                       ` Eli Zaretskii
2024-06-16 11:09                         ` Ihor Radchenko
2024-06-15 16:58                     ` master 5a125fb5a97 1/2: Update to Org 9.7.3 Kyle Meyer
2024-06-11 11:03   ` Stefan Kangas
2024-06-12  3:45     ` Kyle Meyer
2024-06-12  8:52       ` Eli Zaretskii
2024-06-12 12:58         ` Ihor Radchenko
2024-06-12 13:02           ` Eli Zaretskii
2024-06-12 13:21             ` Ihor Radchenko
2024-06-12 13:29               ` Eli Zaretskii
2024-06-12 14:14                 ` Stefan Kangas
2024-06-13 16:12                   ` Ihor Radchenko
2024-06-13 16:48                     ` Eli Zaretskii
2024-06-12 14:46             ` Stefan Monnier
2024-06-12 16:50               ` Eli Zaretskii
2024-06-13 15:44                 ` Ihor Radchenko
2024-06-13 15:55                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871q53u75e.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).