Re: master 5a125fb5a97 1/2: Update to Org 9.7.3

[Ihor Radchenko <yantar92@posteo.net>]

Eli Zaretskii <eliz@gnu.org> writes:

> There are other issues with this update:
>
>     ELC      org/org-macs.elc
>
>   In end of data:
>   org/org-loaddefs.el:1278:78: Warning: the function `cl-every' is not known to be defined.
>
> Can this warning be eliminated, please?

It can be eliminated, but the warning does not seem to be Org mode's
fault.

The line in question in org-loaddefs is

(custom-autoload 'org-num-skip-tags "org-num" t)
(put 'org-num-skip-tags 'safe-local-variable (lambda (val) (and (listp val) (cl-every #'stringp val))))

It is not generated by Org mode, but by loaddefs.el from

(defcustom org-num-skip-tags nil
  "List of tags preventing the numbering of sub-trees.

For example, add \"ARCHIVE\" to this list to avoid numbering
archived sub-trees.

Tag in this list prevent numbering the whole sub-tree,
irrespective to `org-use-tag-inheritance', or other means to
control tag inheritance."
  :group 'org-appearance
  :package-version '(Org . "9.3")
  :type '(repeat (string :tag "Tag"))
  :safe (lambda (val) (and (listp val) (cl-every #'stringp val))))

Note that org-num.el where `org-num-skip-tags' is defined does have
(require 'cl-lib).

IMHO, there is some problem either with loaddefs generation or with the
fact that loaddefs file is compiled at all.

Of course, we can always convert that lambda into a proper function,
which will likely get rid of the warning. (btw, the warning does not
appear when running make bootstrap on my side)

>   Could not read `org-id-locations' from ~/.emacs.d/.org-id-locations, setting it to nil
>
> Why does it want to read a file from my home directory as part of
> building Emacs?  That shouldn't happen.

Agree. But I am unable to reproduce.
Could you please provide more information?

>   Executing Emacs-Lisp code block at position 643527...
>   Code block evaluation complete.
>   Executing Emacs-Lisp code block at position 646480...
>   Code block evaluation complete.
>   Executing Emacs-Lisp code block at position 648303...
>   Code block evaluation complete.
>   Executing Emacs-Lisp code block at position 648968...
>   Code block evaluation complete.
>   Executing Emacs-Lisp code block at position 655333...
>   Code block evaluation complete.
>   Executing Emacs-Lisp code block at position 659159...
>   Code block evaluation complete.
>   Executing Emacs-Lisp code block at position 659467...
>   Code block evaluation complete.
>   Executing Emacs-Lisp code block at position 660552...
>   Code block evaluation complete.
>
> Can we please shut up these messages, or at least hide them behind
> some $(AM_V_GEN) trick?

Why? It is not much different from "scraping loaddefs..." message
sequence.

Of course, we can hide this, but seeing that some code is evaluated may
be useful in the logs.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>