From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 768e92b9c02: Update options that depend on 'which-key-dont-use-unicode' Date: Mon, 24 Jun 2024 19:14:01 +0200 Message-ID: <871q4mb6w6.fsf@gmail.com> References: <171921519771.16563.15139426619834982564@vcs2.savannah.gnu.org> <20240624074638.294E1C1FB6E@vcs2.savannah.gnu.org> <875xtybedy.fsf@gmail.com> <87tthi2xmj.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28872"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 24 19:15:06 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLnHV-0007Eq-NK for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Jun 2024 19:15:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLnGZ-0007Lt-Q7; Mon, 24 Jun 2024 13:14:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLnGZ-0007Le-6G for emacs-devel@gnu.org; Mon, 24 Jun 2024 13:14:07 -0400 Original-Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLnGX-0003uQ-Ir for emacs-devel@gnu.org; Mon, 24 Jun 2024 13:14:06 -0400 Original-Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-361785bfa71so3495705f8f.2 for ; Mon, 24 Jun 2024 10:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719249243; x=1719854043; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=CQ7dUfoiOvvlwFhr+7tqJZueNBaBmr15b+rzNbiK9vo=; b=UXRrpXn0sl6MHlKSyc/AnTPh5V1z+CNhXsCYJ3e37iCNZAsjgzYZ9NMei/56jtIsnf MFZiEAwkXvG33LrIPeYNzvB11TzL4a2PV84wMbjR9MONk/ZSKN2znPZUEwqEC+bj+86T xHAir7sVA8/YjOVRVgfmUm+v17YI4AvgQMVHXgBrlYq8Rh5lekSuDczC35mxsUFaXt3Z osrXnT18g6kCMc7xlvCmO5y5Y7PmHzqdqIg/oRPWAfZIhugBggvP1JpYoa1aYmrfdns8 jWHkr6D7MPB2ARP7QK+VPEGfGMx8w3ZQzpCiS1j0TzMz9uZY5PeJ0W+rYIeGUMJcQ55y qWVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719249243; x=1719854043; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CQ7dUfoiOvvlwFhr+7tqJZueNBaBmr15b+rzNbiK9vo=; b=R6llJiCgE4e/RS3Mf0sZT5BxHB+om9BUoLAzgG05pwjX887FwL6TRRWvqgyKNrsg81 YDFwGR785BGCNu5V7pQoK3DeTBTseO4S0N06P6z7au02GeGRUzWGoH+SE0KkETp6GSqK CVNtXG1NPP/fHEegTq4J1XPo3971kxcoU5rt1+267sHeyekiuwsDX6m283G0Ir4AxJBn Yg5nDjhfMOcXYPq1opobXhhbzEXoxDPBUcuvRm824Tb3ELJvs6vo3NE4C+ueujpxFPDh cWFw8WzPYEwEQzWcxVf5Zpgn/FsnGguBMcau9xrx6eef9PjpS0lR0myeQS/7edKzONKc d7dA== X-Gm-Message-State: AOJu0YxAZt32vwZzJfyNKfzxFTf0wI/WpZvkUQU5DZT7Fm5TKIJNz4yy p7qkm6j5I3YWyzUxvvrxSZySzv+2CLKHLI7QnLATIaS+J7yzZ2pnBI3YJA== X-Google-Smtp-Source: AGHT+IErVYC4bCn482GUefCbGQg+TXqGhtZ5/OxCTosws9wCtez7p5DI0ZJBW2ZZd8Q7XHUjQZRt+g== X-Received: by 2002:a05:6000:188c:b0:366:e20d:6526 with SMTP id ffacd0b85a97d-366e79552d5mr4971210f8f.0.1719249243285; Mon, 24 Jun 2024 10:14:03 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-366383f65easm10604226f8f.23.2024.06.24.10.14.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 10:14:02 -0700 (PDT) In-Reply-To: <87tthi2xmj.fsf@posteo.net> (Philip Kaludercic's message of "Mon, 24 Jun 2024 15:01:24 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=rpluim@gmail.com; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320615 Archived-At: >>>>> On Mon, 24 Jun 2024 15:01:24 +0000, Philip Kaludercic said: >> This commit causes `which-key-separator' and `which-key-ellipsis' to >> be nil for me (after `which-key-mode'). Reverting this commit fixes = it. Philip> Eh, that might be because `which-key-dont-use-unicode' is being Philip> evaluated before the other two options, but the :set function i= s giving Philip> them initial values (nil), even though we haven't determined th= eir Philip> default value yet. Philip> Does Philip> diff --git a/lisp/which-key.el b/lisp/which-key.el Philip> index 91007ce4ada..8b78bfb2576 100644 Philip> --- a/lisp/which-key.el Philip> +++ b/lisp/which-key.el Philip> @@ -133,6 +133,7 @@ which-key-dont-use-unicode Philip> (mapc #'custom-reevaluate-setting Philip> '(which-key-separator Philip> which-key-ellipsis))) Philip> + :initialize #'custom-initialize-changed Philip> :type 'boolean Philip> :package-version "1.0" :version "30.1") =20 Philip> make sense? I am always uncertain which :initialize value to u= se. That works for me, although I won=CA=BCt claim to understand why =F0=9F=98= =80 Robert --=20