Re: Reconsider defaults for use-package-vc-prefer-newest

[Philip Kaludercic <philipk@posteo.net>]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Philip Kaludercic <philipk@posteo.net>
>> Cc: suhailsingh247@gmail.com,  meedstrom@runbox.eu,  emacs-devel@gnu.org,
>>   tonyzorman@mailbox.org
>> Date: Sat, 21 Sep 2024 14:31:21 +0000
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> >> From: Philip Kaludercic <philipk@posteo.net>
>> >> Cc: suhailsingh247@gmail.com,  meedstrom@runbox.eu,  emacs-devel@gnu.org,
>> >>   tonyzorman@mailbox.org
>> >> Date: Fri, 20 Sep 2024 20:43:27 +0000
>> >> 
>> >> Eli Zaretskii <eliz@gnu.org> writes:
>> >> 
>> >> >> From: Philip Kaludercic <philipk@posteo.net>
>> >> >> Cc: suhailsingh247@gmail.com,  meedstrom@runbox.eu,  emacs-devel@gnu.org,
>> >> >>   tonyzorman@mailbox.org
>> >> >> Date: Fri, 20 Sep 2024 15:14:26 +0000
>> >> >> 
>> >> >> Eli Zaretskii <eliz@gnu.org> writes:
>> >> >> 
>> >> >> >> This is the fix:
>> >> >> >
>> >> >> > Can you explain in plain English what this does?
>> >> >> 
>> >> >> Sure, each package has a description object (search for "(cl-defstruct
>> >> >> (package-desc" in package.el), with some fixed attributes like name,
>> >> >> version, dependencies and others that are stored in an alist.  The
>> >> >> commit used to create a package is one such attribute stored in the
>> >> >> "extras" slot of a package-desc.  My chance modifies the package
>> >> >> description given by the ELPA server and updates the :commit field to
>> >> >> store the commit that was checked out when the package was built
>> >> >> locally.  I hope that is clear enough?
>> >> >
>> >> > Yes, thanks.  What was the :commit field storing before the change?
>> >> 
>> >> The commit the ELPA build server used to release a new version of the
>> >> package.
>> >
>> > That is not right, I agree.
>> >
>> >> M-x list-packages lists the commit of the local checkout for
>> >> VC packages, btw.
>> >
>> > What is "the local checkout" in this context?
>> 
>> The checkout of the VC package that the *Help* buffer is describing.
>> 
>> >> I could have sworn that M-x describe-package did the same.
>> >
>> > Shouldn't they all be consistent in what commit they show?
>> 
>> Yes, that is my point.  But since the commit in the package description
>> is not updated when the package is installed, there is a discrepancy.
>
> So your change should make all of them agree?  In that case, please
> install, and thanks.

Right, will do.

-- 
	Philip Kaludercic on siskin