From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Willcock Newsgroups: gmane.emacs.devel Subject: Re: Setup process for etags-regen-mode (Emacs 30.0.91 feedback) Date: Mon, 23 Sep 2024 20:03:03 +0100 Message-ID: <871q1afb14.fsf@ice9.digital> References: <878qvm42ha.fsf@ice9.digital> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26316"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 23 21:04:10 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ssoLw-0006bB-IB for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Sep 2024 21:04:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ssoL8-0002ZA-3g; Mon, 23 Sep 2024 15:03:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssoL4-0002Yw-Fa for emacs-devel@gnu.org; Mon, 23 Sep 2024 15:03:16 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssoKz-0000Z8-O2 for emacs-devel@gnu.org; Mon, 23 Sep 2024 15:03:13 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 21E5BFF802; Mon, 23 Sep 2024 19:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1727118185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b4RWSFlG78thmc/tmq8P8trz+hrw5Jh0//9rsSEt32E=; b=c5WXcYskz2+uEGVVoozGj9zxi3ChVPf31zak4wfHrA3QULiM9rqUxJAMZEisvAwdthk4XL 7QoFw/yEU2xWKoyRoalilBNrwaZ+ybrnOzJZSqCEzXebmar4zqpEvfzVsG64z1ISFhQQqr HVmqDrUQ0+iqPli5eKyz+IETg9iyqPa2w46ok1Ja0Rt8tSDGUHkVGLZxRg+8ziDEsmf2tD 7xS7MWeqd7Yv5rt/HtGzGXP19b8GIAGigHRmmWRFkXetrXpxYFQCJP2Wo/oV3GEC8nSHzF 1rpJWF1j39e8ypRS6aDrkeHRg6261Z9gUsdTIY0rYWrXpUUmerdxb5So0qSDzw== In-Reply-To: (Dmitry Gutov's message of "Mon, 23 Sep 2024 20:17:53 +0300") X-GND-Sasl: morgan@ice9.digital Received-SPF: pass client-ip=217.70.183.199; envelope-from=morgan@ice9.digital; helo=relay9-d.mail.gandi.net X-Spam_score_int: -36 X-Spam_score: -3.7 X-Spam_bar: --- X-Spam_report: (-3.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.928, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323997 Archived-At: Dmitry Gutov writes: >> I wasn't sure whether it was intentional to hard-code the functions to >> advise while etags-regen-mode was still so new, or whether opting in >> other functions hadn't been considered. > > Hadn't been considered yet, but I'm open to the idea. Two basic > approaches is either through a new custom variable, or by making the > function "public". > > The latter is a bit tricky because then we'd need to document what it > does - and it basically launches all the work ((re)scanning the table, > adding the hooks), and that setup might change over time. > >> Would it be possible to store the completion functions which will be >> advised as a separate list, so that other packages can add completion >> functions to that list and get the TAGS generation to trigger? Or is >> this an intentional boundary? > > The custom variable approach seems better, but we'll need to test how it > interacts with being able to switch etags-regen-mode on by default. Hi Dmitry, I'm not in any great hurry to start wiring functions into it, and waiting for more feedback before adding integration features seems the logical thing to do. Thank you for the explanation (and for creating the mode). Morgan -- Morgan Willcock