From: Morgan Willcock <morgan@ice9.digital>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: emacs-devel@gnu.org
Subject: Re: Setup process for etags-regen-mode (Emacs 30.0.91 feedback)
Date: Mon, 23 Sep 2024 20:03:03 +0100 [thread overview]
Message-ID: <871q1afb14.fsf@ice9.digital> (raw)
In-Reply-To: <f20d88c7-bffe-4b9a-ae21-95144c1a5fbb@gutov.dev> (Dmitry Gutov's message of "Mon, 23 Sep 2024 20:17:53 +0300")
Dmitry Gutov <dmitry@gutov.dev> writes:
>> I wasn't sure whether it was intentional to hard-code the functions to
>> advise while etags-regen-mode was still so new, or whether opting in
>> other functions hadn't been considered.
>
> Hadn't been considered yet, but I'm open to the idea. Two basic
> approaches is either through a new custom variable, or by making the
> function "public".
>
> The latter is a bit tricky because then we'd need to document what it
> does - and it basically launches all the work ((re)scanning the table,
> adding the hooks), and that setup might change over time.
>
>> Would it be possible to store the completion functions which will be
>> advised as a separate list, so that other packages can add completion
>> functions to that list and get the TAGS generation to trigger? Or is
>> this an intentional boundary?
>
> The custom variable approach seems better, but we'll need to test how it
> interacts with being able to switch etags-regen-mode on by default.
Hi Dmitry,
I'm not in any great hurry to start wiring functions into it, and
waiting for more feedback before adding integration features seems the
logical thing to do.
Thank you for the explanation (and for creating the mode).
Morgan
--
Morgan Willcock
prev parent reply other threads:[~2024-09-23 19:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 18:14 Setup process for etags-regen-mode (Emacs 30.0.91 feedback) Morgan Willcock
2024-09-23 17:17 ` Dmitry Gutov
2024-09-23 19:03 ` Morgan Willcock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q1afb14.fsf@ice9.digital \
--to=morgan@ice9.digital \
--cc=dmitry@gutov.dev \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).