From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: gerd.moellmann@t-online.de (Gerd Moellmann) Newsgroups: gmane.emacs.devel Subject: Re: [storm@cua.dk: Re: Patch to disable links line in *info* buffer] Date: 23 Jun 2002 11:37:11 +0200 Sender: emacs-devel-admin@gnu.org Message-ID: <86znxmibeg.fsf@gerd.free-bsd.org> References: <200206222251.g5MMprs23105@aztec.santafe.edu> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1024825177 26235 127.0.0.1 (23 Jun 2002 09:39:37 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 23 Jun 2002 09:39:37 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17M3qL-0006p2-00 for ; Sun, 23 Jun 2002 11:39:37 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17M3qw-0007kl-00 for ; Sun, 23 Jun 2002 11:40:14 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 17M3pv-0006MT-00; Sun, 23 Jun 2002 05:39:11 -0400 Original-Received: from mailout08.sul.t-online.com ([194.25.134.20]) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 17M3o7-0006HN-00; Sun, 23 Jun 2002 05:37:19 -0400 Original-Received: from fwd11.sul.t-online.de by mailout08.sul.t-online.com with smtp id 17M3o6-0003MY-04; Sun, 23 Jun 2002 11:37:18 +0200 Original-Received: from gerd.free-bsd.org (520015515780-0001@[217.230.109.152]) by fwd11.sul.t-online.com with esmtp id 17M3o2-0b2NQOC; Sun, 23 Jun 2002 11:37:14 +0200 Original-Received: from gerd.free-bsd.org (localhost [127.0.0.1]) by gerd.free-bsd.org (8.12.3/8.12.3) with ESMTP id g5N9bCUB015103; Sun, 23 Jun 2002 11:37:12 +0200 (CEST) (envelope-from gerd.moellmann@t-online.de) Original-Received: (from gerd@localhost) by gerd.free-bsd.org (8.12.3/8.12.3/Submit) id g5N9bBla014933; Sun, 23 Jun 2002 11:37:11 +0200 (CEST) X-Authentication-Warning: gerd.free-bsd.org: gerd set sender to gerd.moellmann@t-online.de using -f Original-To: rms@gnu.org In-Reply-To: <200206222251.g5MMprs23105@aztec.santafe.edu> Original-Lines: 48 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-Sender: 520015515780-0001@t-dialin.net Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.9 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:5114 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:5114 Richard Stallman writes: > Would you please help us with this? You know this code more > than anyone. > > From: storm@cua.dk (Kim F. Storm) > Subject: Re: Patch to disable links line in *info* buffer > To: rms@gnu.org > Cc: "Stefan Monnier" , jasonr@gnu.org, > bob@rattlesnake.com, emacs-devel@gnu.org > Date: 22 Jun 2002 01:56:31 +0200 > > no-spam@cua.dk (Kim F. Storm) writes: > > > "Stefan Monnier" writes: > > > > > > The problem is that there is no named face which has this appearence, > > > > so I cannot simply put a (face mode-line-bold) property on the string > > > > returned by format-mode-line. > > > > > > Any reason why you can't use (face (mode-line bold)) ? > > > > Not anymore :-) > > Ok, I have changed format-mode-line to return a propertized string > (changes are not committed yet), but the "face merging" doesn't always > give the same result as the actual mode line: > > This combination works (*Help* is bold): > > (insert '#("-1:%% *Help* ..." > 7 13 (face (mode-line :weight bold)))) > > but this doesn't (*Help* isn't bold): > > (insert '#("-1:%% *Help* ..." > 7 13 (face (mode-line-inactive :weight bold)))) The above list form of face property value doesn't look right. I think it should be something like (mode-line (:weight bold)) instead. Each element of the list should be either a named face or a list of face attributes; see also the Lisp Reference. The face property value above looks like it will use the non-existent named face `:weight'. Since faces from a list-valued face property are merged from left to right (AFAIR), the faces in the list should also be reversed: ((:weight bold) mode-line). Otherwise, if mode-line explicitly specifies a weight, the (:weight bold) will have no effect.