build is broken on OSX today

build is broken on OSX today

[Randal L. Schwartz]

Compiled just fine yesterday.  Latest commit I see is:

commit e7620eddea6d3b60309125d3ca958f39a68a6f59
Author: Dmitry Antipov <dmantipov@yandex.ru>
Date:   Thu Jun 28 16:29:37 2012 +0400

    * window.h (struct window): Change type of 'hscroll',
    'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
    'last_modified' and 'last_overlay_modified' to EMACS_INT.
    Adjust users accordingly.
    * xdisp.c (try_cursor_movement): Replace type check with eassert.
    * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
    from EMACS_INT to ptrdiff_t.
    (make_window): Omit redundant initialization.


If I get time, I'll bisect it.

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Smalltalk/Perl/Unix consulting, Technical writing, Comedy, etc. etc.
See http://methodsandmessages.posterous.com/ for Smalltalk discussion

Re: build is broken on OSX today

[Dmitry Antipov]

On 06/28/2012 09:33 PM, Randal L. Schwartz wrote:
>
> Compiled just fine yesterday.  Latest commit I see is:
>
> commit e7620eddea6d3b60309125d3ca958f39a68a6f59
> Author: Dmitry Antipov <dmantipov@yandex.ru>
> Date:   Thu Jun 28 16:29:37 2012 +0400
>
>      * window.h (struct window): Change type of 'hscroll',
>      'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
>      'last_modified' and 'last_overlay_modified' to EMACS_INT.
>      Adjust users accordingly.
>      * xdisp.c (try_cursor_movement): Replace type check with eassert.
>      * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
>      from EMACS_INT to ptrdiff_t.
>      (make_window): Omit redundant initialization.
>
>
> If I get time, I'll bisect it.

Oops, sorry. Can you post error messages here?

Dmitry

Re: build is broken on OSX today

[Drew Raines]

Randal L. Schwartz wrote:

> Compiled just fine yesterday.  Latest commit I see is:
>
> commit e7620eddea6d3b60309125d3ca958f39a68a6f59

[...]

> If I get time, I'll bisect it.

I found the same thing this morning and bisected.  git told me it was:

    commit 564ebbd2a22ff6fbed4b1678a48710c7ffd6e7df
    Author: Dmitry Antipov <dmantipov@yandex.ru>
    Date:   Thu Jun 28 11:50:27 2012 +0400
    
        Generalize run-time debugging checks.
        * configure.in (ENABLE_CHECKING): Update comment.
        * src/dispextern.h (XASSERTS): Remove.
        * src/fontset.c (xassert): Remove.
        Convert from xassert to eassert.
        * src/alloc.c: Convert from xassert to eassert.
        * src/bidi.c: Likewise.
        * src/dispnew.c: Likewise.
    
        [...]

The error I see is:

    Undefined symbols:
      "_xassert", referenced from:
          _ns_after_update_window_line in nsterm.o
          _update_frame_tool_bar in nsmenu.o
    ld: symbol(s) not found
    collect2: ld returned 1 exit status
    make[2]: *** [temacs] Error 1
    make[1]: *** [src] Error 2
    make: *** [bootstrap] Error 2

A little more context: http://p.draines.com/1340908901307eb95d24b.txt

-Drew

Re: build is broken on OSX today

[Dmitry Antipov]

On 06/28/2012 10:43 PM, Drew Raines wrote:

> Randal L. Schwartz wrote:
>
>> Compiled just fine yesterday.  Latest commit I see is:
>>
>> commit e7620eddea6d3b60309125d3ca958f39a68a6f59
>
> [...]
>
>> If I get time, I'll bisect it.
>
> I found the same thing this morning and bisected.  git told me it was:

Should be fixed now.

Dmitry

Re: build is broken on OSX today

[Drew Raines]

Dmitry Antipov wrote:

> Should be fixed now.

It is.  Thanks!

-Drew