build failure emacs-26 branch on Mingw64

build failure emacs-26 branch on Mingw64

[Stephen Leake]

Building emacs-26 branch on Mingw64, in a fresh checkout, configure
fails with:

config.status: executing src/epaths.h commands
sed: -e expression #1, char 79: unknown option to `s'
make: *** [Makefile:383: epaths-force-w32] Error 1
config.status: error: 'src/epaths.h' could not be made.

I'll investigate further.

-- 
-- Stephe

Re: build failure emacs-26 branch on Mingw64

[Stephen Leake]

Stephen Leake <stephen_leake@stephe-leake.org> writes:

> Building emacs-26 branch on Mingw64, in a fresh checkout, configure
> fails with:
>
> config.status: executing src/epaths.h commands
> sed: -e expression #1, char 79: unknown option to `s'
> make: *** [Makefile:383: epaths-force-w32] Error 1
> config.status: error: 'src/epaths.h' could not be made.
>
> I'll investigate further.

The sed command that gives the error is:

  -e 's;\(#.*PATH_SITELOADSEARCH\).*$$;\1 "'"$${w32locallisppath//;/\\;}"'";'

There is an unquoted ; in the replacement, but quoting that does not fix
the error.

I'm guessing the reference to 'w32locallisppath' is supposed to replace
the Unix path separator : with the Windows path separator ; . But the
shell syntax for that would be:

${w32locallisppath/:/;}

The escaped make syntax would then be:

$${w32locallisppath/:/\\;}

but that doesn't fix the error either. And 'msys-to-w32' has already
done that substitution, so doing it here is wrong.

I could not find a variation that fixes the error.


'git blame' says this line was last edited in 2014:

7c86a2a7d82 (Dani Moncayo    2014-11-08 15:55:09 +0100  388) 	  -e 's;\(#.*PATH_SITELOADSEARCH\).*$$;\1 "'"$${w32locallisppath//;/\\;}"'";' \

so this has apparently been working for a long time; I don't understand
why it's failing for me now.


I don't specify --enable-locallisppath, so I can work around this by
simply deleting that line from Makefile.in. That lets configure complete.

--
-- Stephe

Re: build failure emacs-26 branch on Mingw64

[Andreas Schwab]

On Jan 01 2018, Stephen Leake <stephen_leake@stephe-leake.org> wrote:

> The sed command that gives the error is:
>
>   -e 's;\(#.*PATH_SITELOADSEARCH\).*$$;\1 "'"$${w32locallisppath//;/\\;}"'";'
>
> There is an unquoted ; in the replacement, but quoting that does not fix
> the error.

The regexp separator for the s command should be changed to something
else than `;' to avoid a quoting nightmare.

> I'm guessing the reference to 'w32locallisppath' is supposed to replace
> the Unix path separator : with the Windows path separator ; .

No, it replaces `;' with `\;' so that it can be interpolated into the
replacement part of the s command.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: build failure emacs-26 branch on Mingw64

[Richard Copley]

On 1 January 2018 at 12:51, Andreas Schwab <schwab@linux-m68k.org> wrote:
> On Jan 01 2018, Stephen Leake <stephen_leake@stephe-leake.org> wrote:
>
>> The sed command that gives the error is:
>>
>>   -e 's;\(#.*PATH_SITELOADSEARCH\).*$$;\1 "'"$${w32locallisppath//;/\\;}"'";'
>>
>> There is an unquoted ; in the replacement, but quoting that does not fix
>> the error.
>
> The regexp separator for the s command should be changed to something
> else than `;' to avoid a quoting nightmare.
>
>> I'm guessing the reference to 'w32locallisppath' is supposed to replace
>> the Unix path separator : with the Windows path separator ; .
>
> No, it replaces `;' with `\;' so that it can be interpolated into the
> replacement part of the s command.

Building the emacs-26 branch from scratch works fine for me.
If I insert an echo command in Makefile (see patch below),
then run "make epaths-force-w32", the output is

s;\(#.*PATH_SITELOADSEARCH\).*$;\1
"%emacs_dir%/share/emacs/26.0.90/site-lisp\;%emacs_dir%/share/emacs/site-lisp";

Stephe, what do you get?

The patch:
--- c:/projects/emacs/Makefile
+++ #<buffer Makefile>
@@ -384,6 +384,7 @@
       w32prefix=`${srcdir}/build-aux/msys-to-w32 "${prefix}"`; \
       w32locallisppath=`${srcdir}/build-aux/msys-to-w32 "${locallisppath}"` ; \
       w32locallisppath=$${w32locallisppath//$${w32prefix}/"%emacs_dir%"} ; \
+      echo 's;\(#.*PATH_SITELOADSEARCH\).*$$;\1
"'"$${w32locallisppath//;/\\;}"'";' ; \
       sed < ${srcdir}/nt/epaths.nt > epaths.h.$$$$        \
       -e 's;\(#.*PATH_SITELOADSEARCH\).*$$;\1
"'"$${w32locallisppath//;/\\;}"'";' \
       -e '/^.*#/s/@VER@/${version}/g'             \

Re: build failure emacs-26 branch on Mingw64

[Stephen Leake]

Richard Copley <rcopley@gmail.com> writes:

> On 1 January 2018 at 12:51, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> On Jan 01 2018, Stephen Leake <stephen_leake@stephe-leake.org> wrote:
>>
>>> The sed command that gives the error is:
>>>
>>>   -e 's;\(#.*PATH_SITELOADSEARCH\).*$$;\1 "'"$${w32locallisppath//;/\\;}"'";'
>>>
>>> There is an unquoted ; in the replacement, but quoting that does not fix
>>> the error.
>>
>> The regexp separator for the s command should be changed to something
>> else than `;' to avoid a quoting nightmare.
>>
>>> I'm guessing the reference to 'w32locallisppath' is supposed to replace
>>> the Unix path separator : with the Windows path separator ; .
>>
>> No, it replaces `;' with `\;' so that it can be interpolated into the
>> replacement part of the s command.
>
> Building the emacs-26 branch from scratch works fine for me.

I'm guessing you are using the same tools I am.

Are you running configure from the mingw64 shell? Which make is
first in path?

As discussed in the thread on my other build failure, this is fixed by
using /usr/bin/make

> If I insert an echo command in Makefile (see patch below), then run
> "make epaths-force-w32", 

You can get the same effect by removing the '@'; that makes the entire
command visible.


-- 
-- Stephe