From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 86c4e5a2fb3: Fix implicit declaration of bswap_{32,64}
Date: Sat, 30 Mar 2024 11:16:32 +0300
Message-ID: <86zfugcexr.fsf@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="3428"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Andreas Schwab <schwab@gnu.org>, Paul Eggert <eggert@cs.ucla.edu>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 30 09:18:29 2024
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1rqTv2-0000gH-9f
	for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Mar 2024 09:18:28 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1rqTtG-0002zt-LF; Sat, 30 Mar 2024 04:16:38 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1rqTtE-0002zU-Du
 for emacs-devel@gnu.org; Sat, 30 Mar 2024 04:16:36 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1rqTtB-0006ib-KA; Sat, 30 Mar 2024 04:16:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to:
 references; bh=aDUqTj9Iv5T9Bynmt6dqrxNHiB0Q5vYytILGS2S25ao=; b=DyMVsFwz4AlkpR
 5pyvq7ihU9wmeKNrIBRMU6lQbodfsaV88A7sssWUOLMk8mxWN1oWDAylixT6Mw53s27388tsynZHe
 4bl10iwFlSM9h6SWUFuBNHiCOYRmCIJ78wAk5KMa4yQiM+NLSBYdqROWOJ6U5ycmLMFRmIxKrC+l5
 aEv6Gp1UuChRfcVNyi/VMHLvaQ6/Sz1FJOdovvnG1yW6a2zm7HpZ+T2losUY93qmtzxCT+VtryfHX
 SOlrDO/nqxd/i7m6ggZvwBhfMKng7YmGZJoXaAC/JpTtAGNPdPJxsGz0U3OHN/QM+B81xwIx5lfvc
 evCF9t8BroZPxnHlg87Q==;
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:317386
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/317386>

> branch: master
> commit 86c4e5a2fb3fd6b7acb8a3fc10e1e7c2eb8012a9
> Author: Andreas Schwab <schwab@linux-m68k.org>
> Commit: Andreas Schwab <schwab@linux-m68k.org>
> 
>     Fix implicit declaration of bswap_{32,64}
>     
>     * src/data.c: Move include of <byteswap.h> ...
>     * src/lisp.h: ... here.

Wouldn't it be better to use __builtin_bswap32 when it's available?

Paul, why doesn't Gnulib do that in its byteswap.h header?