From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: bug#70019: [PATCH] Fix two bugs in removing bookmark fringe marks (bug#70019) Date: Mon, 22 Apr 2024 10:40:42 +0300 Message-ID: <86zftl6e11.fsf@gnu.org> References: <87r0f26ia6.fsf@red-bean.com> <87zftoq2fp.fsf@red-bean.com> <87jzkqawc0.fsf@red-bean.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33066"; mail-complaints-to="usenet@ciao.gmane.io" Cc: kfogel@red-bean.com, 70019@debbugs.gnu.org, emacs-devel@gnu.org To: Dani Moncayo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 22 09:41:41 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ryoJ3-0008Nx-08 for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Apr 2024 09:41:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ryoIH-0005Zx-SM; Mon, 22 Apr 2024 03:40:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryoIA-0005UT-A7 for emacs-devel@gnu.org; Mon, 22 Apr 2024 03:40:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryoI9-0007Nr-K7; Mon, 22 Apr 2024 03:40:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=tduGq91S40BrU3Hs2mr3YPgQgDcT03DhLDxA4eHX42M=; b=q6jseZSejJtl/eeJNW4i Xkqeq4kNrSkoFz81QqARKH2xYXq1BJcsPXR9kWgfQ+FTHXWG52y6gcrfpWRNLYQPNauoYWNwdzze1 zrh59phPZEVBkhvkbTpy5npfmbkE85i0VwGrnE5R15J9mFQYbcJOR8+8OqE8ZXnRxyLmZSne4qxfZ WnlH756Eb5HXGnWOJDYrIwJVDQfab5s9X0TQT3p5pSWHiLinG3dh5wg3hYLfwfu8yXUan3Yjqw7bZ HNxYn8IvtRaXccDOYlEIhzIvc77ze3GZEqNfVdiFFEsItlBG3quEVHzLpo6cY2pO9xWyi0m8IXdi9 979WjJaXjrT4Wg==; In-Reply-To: (message from Dani Moncayo on Mon, 22 Apr 2024 08:26:41 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317957 Archived-At: > Cc: 70019@debbugs.gnu.org, Emacs Developers > From: Dani Moncayo > Date: Mon, 22 Apr 2024 08:26:41 +0200 > > On Mon, Apr 22, 2024 at 5:51 AM Karl Fogel wrote: > > [...] > > > > In general, there's no mechanism for a bookmark fringe mark to be > > shown when one goes to a bookmarked location by some means *other* > > than through a bookmark function. > > > > [...] > > Hi Karl. > > OK, Thanks for your work on this, and for your explanations, which I understand. > > I intuitively expected the fringe icon to be shown at its current > location, whenever that location is visible, regardless of other > considerations. > > We both agree that it would be a nice feature, but not at any price. > > I'm OK with your fix, then. Thanks. Thanks. Karl, please install the patch on the master branch, and close the bug when you do.