From: Eli Zaretskii <eliz@gnu.org>
To: Pip Cet <pipcet@protonmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: scratch/igc 90e80a9a53e 6/6: Adjust igc.c code to header changes
Date: Sun, 21 Jul 2024 17:25:19 +0300 [thread overview]
Message-ID: <86zfqabz5c.fsf@gnu.org> (raw)
In-Reply-To: <EPbmDango3IrIOmivQQ7yNrz2dqN1w-fn2ppTEs7ndYW8m-l7Rz_g-VvjBXKKK1lnZBBznCYuq9qSEjhVTabScTEwYFrKVC90785-fsod1s=@protonmail.com> (message from Pip Cet on Sun, 21 Jul 2024 14:11:56 +0000)
> Date: Sun, 21 Jul 2024 14:11:56 +0000
> From: Pip Cet <pipcet@protonmail.com>
> Cc: emacs-devel@gnu.org
>
> > Does the below help?
> >
> > #4 dump_write (ctx=0x71ceb38, buf=0x71ce848, nbyte=8) at pdumper.c:792
> > 792 dump_write (struct dump_context *ctx, const void *buf, dump_off nbyte)
> > (gdb) p ctx->igc_obj_dumped
> >
> > $1 = (void *) 0xc3f000 <Sinternal_show_cursor_p>
>
> Thanks, that helps a lot! It's an internal subr, and those don't store their proper size in the pseudovector header, so we don't dump them properly as we trust the pseudovector header.
>
> I've managed to reproduce something similar here, and the attached patch helps, but it probably breaks GC in the !HAVE_MPS case.
Why cannot you identify this kind of object during dumping, and avoid
applying whatever igc_dump_finish_obj does? There's the PVEC_SUBR in
the struct, no?
next prev parent reply other threads:[~2024-07-21 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-21 10:47 scratch/igc 90e80a9a53e 6/6: Adjust igc.c code to header changes Eli Zaretskii
2024-07-21 11:42 ` Pip Cet
2024-07-21 12:07 ` Eli Zaretskii
2024-07-21 14:11 ` Pip Cet
2024-07-21 14:25 ` Eli Zaretskii [this message]
2024-07-21 16:20 ` Pip Cet
2024-07-21 16:27 ` Eli Zaretskii
2024-07-22 14:35 ` Pip Cet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zfqabz5c.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=pipcet@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).