From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: On committing significant and/or controversial changes Date: Fri, 22 Nov 2024 21:01:04 +0200 Message-ID: <86zflrm6tr.fsf@gnu.org> References: <87ldxb9o3q.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30424"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 22 20:02:00 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEYul-0007gi-Ad for ged-emacs-devel@m.gmane-mx.org; Fri, 22 Nov 2024 20:01:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEYtz-0003da-8E; Fri, 22 Nov 2024 14:01:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEYtw-0003d4-Di for emacs-devel@gnu.org; Fri, 22 Nov 2024 14:01:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEYtw-0005fu-4b; Fri, 22 Nov 2024 14:01:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iQQS3YK6inIoEBAu3kWi2pib9uKGVbM1sma8jVuaImw=; b=H8RE7oNqSS33 CdHVa2rqyXiF2LIILYVWXrQeZXZebifzER+5HclqvQngVZ/uV8jDexD4PlGtkbuHF/cwaWDcovvRf JIZcaAFpwes1K4TqNx+FhZLn48s+Xh+auy8wFY3+oanyLevYthRZIsozfrL13X/syT+EeA6Cgz9GA /x9pvfSANj9dAZTfNeD+Lo/cZH0o7deOKYGqH9KS5PIwyAQH53h5pG9VNUPj+cvrOQDK5eE8qsyRH hHtd8DHTErU3zqHbIC9lRmXQRYGWuka8pr7K24MdWu82M8XHQT8O2+Hc5JFuAeDoYPB4pRJFtsY/j nYqS1X8rRRUTA3VqtCcz3g==; In-Reply-To: <87ldxb9o3q.fsf@localhost> (message from Ihor Radchenko on Fri, 22 Nov 2024 17:26:17 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325598 Archived-At: > From: Ihor Radchenko > Cc: emacs-devel@gnu.org > Date: Fri, 22 Nov 2024 17:26:17 +0000 > > 1. Make a rule that non-trivial changes and new features _must_ be > announced on emacs-devel at least a month (or week?) in advance > before committing them, and are only committed if there is no > significant discussion or after the discussion is settled > > If no announcement is made, they are reverted (temporarily), the > announcement is made, so that discussion has a chance to happen. There's no need for a rule, since this is common sense. All the contributors are expected to behave like that, and if they don't, they should expect post-factum objections, discussions, and the danger of reverting the offending changes. > 2. Make a rule that judgment calls are clearly indicated. If some change > sparks controversy/discussion and maintainer has to choose among > multiple solutions, such decision should be done in a separate, > clearly marked email, with a link to commit. This is also common sense, and already followed. Of course "clearly indicated" is in the eyes of the beholder, so what is clearly indicated" for me might not be so for others. Bottom line: we already expect everyone to behave like that, and I see no need to codify what common sense tells us.