From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 8064b2a6798: Document undocumented completion commands Date: Sun, 05 Jan 2025 11:15:29 +0200 Message-ID: <86zfk58vv2.fsf@gnu.org> References: <173506838079.2264184.7348874799811402829@vcs3.savannah.gnu.org> <20241224192621.31046CA6ED0@vcs3.savannah.gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3116"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 05 10:16:28 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tUMkG-0000hH-7K for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Jan 2025 10:16:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tUMje-000781-2a; Sun, 05 Jan 2025 04:15:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUMjQ-00076f-Ge for emacs-devel@gnu.org; Sun, 05 Jan 2025 04:15:36 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUMjQ-0007gi-1A; Sun, 05 Jan 2025 04:15:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=l3S5f5ph8WkZ6BphVyUKxQviqWddQR9HLEge5mbBKUo=; b=dskzigH1lOr/ JGLPJhdlMux4Pu4vFrsoy88c2eLyng0Oto6TpDZyYbc+k6YV6z5XUh3Rw7Oor67RdSou6XBOGKK+c 5FxHTUPicAdfiAE3P1cPaC3iNvIMsy+414F9kUSWvyb545SEW+qlopC4autBAuCRUB6bZ3wEIWGYU GhH9GdDHDesldMKz+jzaX7K4SNGOZ3nwuU/6rTz7inFpUmGZcmQJ2BcTBcFTJPQAThj6v21y3Aipt 4Ywx3b0clZn4d6UVsdKb4J2g5WQTflzUK6ggnQWbf9aiJRvzIHmCaju3I5s10xwQjXL+FSBW179d7 4k4w4b1ySktQyI98TctJyw==; In-Reply-To: (message from Eshel Yaron on Sun, 05 Jan 2025 09:06:04 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327712 Archived-At: > From: Eshel Yaron > Cc: Eli Zaretskii > Date: Sun, 05 Jan 2025 09:06:04 +0100 > > > diff --git a/src/minibuf.c b/src/minibuf.c > > index f16880011f7..83b1fa024f8 100644 > > --- a/src/minibuf.c > > +++ b/src/minibuf.c > > @@ -1293,6 +1293,11 @@ barf_if_interaction_inhibited (void) > > DEFUN ("read-from-minibuffer", Fread_from_minibuffer, > > Sread_from_minibuffer, 1, 7, 0, > > doc: /* Read a string from the minibuffer, prompting with string PROMPT. > > +While in the minibuffer, you can use \\\\[minibuffer-complete] and \\[minibuffer-complete-word] to complete your input. > > +You can also use \\\\[minibuffer-complete-history] to complete using history items in the > > +input history HIST, and you can use \\[minibuffer-complete-defaults] to complete using > > +the default items in DEFAULT-VALUE. > > + > > The optional second arg INITIAL-CONTENTS is an obsolete alternative to > > DEFAULT-VALUE. It normally should be nil in new code, except when > > HIST is a cons. It is discussed in more detail below. > > This part isn't quite right: read-from-minibuffer does not provide > completion with minibuffer-complete[-word] by default. > > How about just dropping these references? Sorry, I don't want to drop them, they are important. Why do you say these are not supported by default? I can use them in "emacs -Q", so what did I miss? In any case, if these commands need something to enable them, I prefer to spell that out in the doc string. These commands are important, and having them undocumented is not acceptable, IMO.