From: Stephen Leake <stephen_leake@stephe-leake.org>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Re: change pcomplete/make to include targets in included files
Date: Sun, 15 Sep 2019 12:50:56 -0700 [thread overview]
Message-ID: <86y2ypnxsv.fsf@stephe-leake.org> (raw)
In-Reply-To: <jwvd0g2pkfh.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 14 Sep 2019 21:43:41 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Stephen Leake [2019-09-14 02:46:16] wrote:
>> To make this actually work in the prompt for 'compile', I had to modify
>> `shell-dynamic-complete-functions' to contain just
>> `pcomplete-completions-at-point'; I have not figured out why yet.
>
> I don't see this change in the patch (which I think is good), so
> I assume you're waiting to figure it out before acting on it, right?
Right; see other post about "fix for bug#34330"
> I think dropping text-properties is OK, but you can do it with
> (match-string-no-properties 1).
> Other than dropping properties, you can also optimize the code using
> `nconc` instead of `append`.
Done.
>> +(defun pcmpl-gnu-make-all-targets (makefile)
>> + "Return a list of target names in MAKEFILE and all included files."
>> + (with-temp-buffer
>> + (ignore-errors ;Could be a directory or something.
>> + (insert-file-contents makefile))
>
> I think we could use `with-demoted-errors` here, since the error case
> should only occur in cases where there's really something odd which the
> user may want to be know about.
Done.
> >
>> + (let ((filenames (when pcmpl-gnu-makefile-includes (pcmpl-gnu-make-includes)))
>> + (targets (pcmpl-gnu-make-targets)))
>> + (dolist (file filenames)
>> + (when (file-readable-p file)
>> + (setq targets (append (pcmpl-gnu-make-all-targets file) targets))))
>> + targets)))
>
> You can completely eliminate this `append` by passing the `targets`
> argument as an additional arg to pcmpl-gnu-make-all-targets (itself
> passed to pcmpl-gnu-make-targets).
That doesn't seem to work. The list ('rules' in
pcmp-gnu-with-file-buffer) is initially nil, which means it is not
passed by reference, so it is never updated. Unless there is some way to
force pass by reference? (I think that requires a macro?)
--
-- Stephe
next prev parent reply other threads:[~2019-09-15 19:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-14 9:46 change pcomplete/make to include targets in included files Stephen Leake
2019-09-14 10:08 ` Eli Zaretskii
2019-09-14 10:57 ` Eli Zaretskii
2019-09-14 22:04 ` Stephen Leake
2019-09-14 22:03 ` Stephen Leake
2019-09-15 1:43 ` Stefan Monnier
2019-09-15 19:50 ` Stephen Leake [this message]
2019-09-15 20:56 ` Stefan Monnier
2019-09-16 23:33 ` Stephen Leake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86y2ypnxsv.fsf@stephe-leake.org \
--to=stephen_leake@stephe-leake.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).