From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: repeat-mode: Setting `repeat-map' property to a keymap object fails Date: Thu, 25 Nov 2021 09:59:29 +0200 Organization: LINKOV.NET Message-ID: <86y25cvf6p.fsf@mail.linkov.net> References: <87tug1qoej.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3338"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Narendra Joshi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 25 09:17:39 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mq9wp-0000fl-9T for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Nov 2021 09:17:39 +0100 Original-Received: from localhost ([::1]:59284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mq9wo-0000Bv-7A for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Nov 2021 03:17:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mq9gJ-0001a3-To for emacs-devel@gnu.org; Thu, 25 Nov 2021 03:00:35 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:41047) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mq9gH-0007Ux-Bw for emacs-devel@gnu.org; Thu, 25 Nov 2021 03:00:35 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 56D3E24000B; Thu, 25 Nov 2021 08:00:29 +0000 (UTC) In-Reply-To: <87tug1qoej.fsf@gmail.com> (Narendra Joshi's message of "Wed, 24 Nov 2021 21:39:16 +0100") Received-SPF: pass client-ip=217.70.178.230; envelope-from=juri@linkov.net; helo=relay10.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280074 Archived-At: > I tried to use a `keymap' object as the value of the `repeat-map' > property of a symbol/command and it failed. I think the change below > would avoid the problem. The problem is that `boundp` throws an error > for anything other than a symbol value. > > diff --git a/lisp/repeat.el b/lisp/repeat.el > index 4dcd353e34..32ffb1884f 100644 > --- a/lisp/repeat.el > +++ b/lisp/repeat.el > @@ -416,7 +416,7 @@ repeat-post-hook > (and (symbolp real-this-command) > (get real-this-command 'repeat-map))))) > (when rep-map > - (when (boundp rep-map) > + (when (and (symbolp rep-map) (boundp rep-map)) > (setq rep-map (symbol-value rep-map))) > (let ((map (copy-keymap rep-map))) Thanks, fixed now.