From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Date: Mon, 03 Jan 2022 09:45:59 +0200 Organization: LINKOV.NET Message-ID: <86y23xuv8g.fsf@mail.linkov.net> References: <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org> <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> <871r1v8nhf.fsf@gnus.org> <83ilv7jqm7.fsf@gnu.org> <6a9cd581-1630-4a95-62c4-419603561072@gmx.at> <3499cedf-b170-3045-873d-d45d2972ae13@gmx.at> <0f492ac4-4167-5448-2c74-a5f67950eae4@yandex.ru> <2de2323b-6d34-9263-776b-dbeff036f8f4@gmx.at> <87zgog68ni.fsf@gnus.org> <8dfc6f22-d331-e7c1-b536-2d374197528f@gmx.at> <86v8z26o15.fsf@mail.linkov.net> <9d5f512f-dd10-fb6b-2fe7-db24ed92f7c8@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32407"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: martin rudalics , Lars Ingebrigtsen , sdsg@amazon.com, Eli Zaretskii , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 03 08:57:42 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n4IDu-0008G6-6T for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Jan 2022 08:57:42 +0100 Original-Received: from localhost ([::1]:43918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4IDr-0002Jk-Sd for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Jan 2022 02:57:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4ICV-0000zw-GX for emacs-devel@gnu.org; Mon, 03 Jan 2022 02:56:15 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:57695) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4ICT-0002Jq-Fg; Mon, 03 Jan 2022 02:56:15 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 875FE240018; Mon, 3 Jan 2022 07:56:07 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Sun, 2 Jan 2022 22:52:37 +0200") Received-SPF: pass client-ip=217.70.183.193; envelope-from=juri@linkov.net; helo=relay1-d.mail.gandi.net X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284002 Archived-At: >> > Then a condition predicate could check for this tag: >> > >> >    (defun display-buffer-comint (buffer-name action) >> >      (assq 'comint action)) >> > >> If we do that we should first make a list of possible tags like 'occur' >> or 'info' and check whether we should provide similar functions for them >> too. > > Perhaps the customized value structure should simply refer to major mode(s)? > > Then there won't be a need to create a predefined list with mappings. Indeed, this is what I use for the outbound buffer: #+begin_src emacs-lisp (defun display-buffer-from-grep-p (_buffer-name _action) (with-current-buffer (window-buffer) (or (derived-mode-p 'compilation-mode) (derived-mode-p 'xref--xref-buffer-mode)))) (add-to-list 'display-buffer-alist '(display-buffer-from-grep-p (display-buffer-same-window (inhibit-same-window . nil)))) #+end_src So it's possible to do the same for the inbound buffer: #+begin_src emacs-lisp (defun display-buffer-to-comint-p (buffer-name _action) (with-current-buffer (get-buffer buffer-name) (derived-mode-p 'comint-mode))) (add-to-list 'display-buffer-alist '(display-buffer-to-comint-p (display-buffer-same-window (inhibit-same-window . nil)))) #+end_src