Re: * lisp/progmodes/eglot.el (eglot--connect): Use project-name

Re: * lisp/progmodes/eglot.el (eglot--connect): Use project-name

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

Stephen,

In this commit:

commit 1f39da3098a2a4cec9985e6db934ed14b7b522b7
Author: Stephen Leake <stephen_leake@stephe-leake.org>
Date:   Tue Nov 22 11:43:22 2022 -0800

    * lisp/progmodes/eglot.el (eglot--connect): Use project-name

    As discussed in bug#48747.

You use an fboundp check for the project-name function recently
added to project.el.

This is not necessary in eglot.el, since it already depends on the
project.el :core ELPA package.  eglot.el is itself such a package.
So you must merely bump the "Version:" of the project.el package in
that file and then make eglot.el reference the new version in its
"Package-Requires:".

Of course you should/could ask permission before bumping
project.el's version (or not, depends on Dmitry's policy)

This way we can avoid those pesky checks. I'll change the commit
to use package-name directly now.

João

PS: When about to apply a patch to eglot.el, even one where I
have already approved the underlying idea, I would appreciate
it if you could just shoot me a personal mail showing the full
contents of the patch.

[-- Attachment #2: Type: text/html, Size: 1542 bytes --]

Re: [SPAM UNSURE] Re: * lisp/progmodes/eglot.el (eglot--connect): Use project-name

[Stephen Leake]

João Távora <joaotavora@gmail.com> writes:

> You use an fboundp check for the project-name function recently
> added to project.el.
>
> This is not necessary in eglot.el, since it already depends on the
> project.el :core ELPA package.  eglot.el is itself such a package.
> So you must merely bump the "Version:" of the project.el package in
> that file and then make eglot.el reference the new version in its
> "Package-Requires:".

Ok.

> Of course you should/could ask permission before bumping
> project.el's version (or not, depends on Dmitry's policy)

Right.

> PS: When about to apply a patch to eglot.el, even one where I
> have already approved the underlying idea, I would appreciate
> it if you could just shoot me a personal mail showing the full
> contents of the patch.

Ok

-- 
-- Stephe

Re: * lisp/progmodes/eglot.el (eglot--connect): Use project-name

[Dmitry Gutov]

On 24/11/22 16:43, João Távora wrote:
> So you must merely bump the "Version:" of the project.el package in
> that file and then make eglot.el reference the new version in its
> "Package-Requires:".

You could also wait until the new version if out and then bump the 
required version and simplify.

Re: * lisp/progmodes/eglot.el (eglot--connect): Use project-name

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]

  On Thu, Nov 24, 2022 at 9:35 PM Dmitry Gutov <dgutov@yandex.ru> wrote:
>
> On 24/11/22 16:43, João Távora wrote:
> > So you must merely bump the "Version:" of the project.el package in
> > that file and then make eglot.el reference the new version in its
> > "Package-Requires:".
>
> You could also wait until the new version if out and then bump the
> required version and simplify.

Not sure I understood correctly, but that's two changes instead of one,
and unnecessary "VC churn".  Also, I forgot to mention that adding
project-name _without_ the fboundp is fine even without any version
bumping.  It's only when eglot.el is bumped after that that we must
ensure project.el is also bumped.

Is there a regular project.el release schedule? Eglot doesn't really have
one itself.  It's "whenever it's convenient".

João

[-- Attachment #2: Type: text/html, Size: 1079 bytes --]

Re: * lisp/progmodes/eglot.el (eglot--connect): Use project-name

[Dmitry Gutov]

On 25/11/22 11:28, João Távora wrote:
> Is there a regular project.el release schedule? Eglot doesn't really have
> one itself.  It's "whenever it's convenient".

Nope. I just wanted to get in a few more changes before bumping.