From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of passwords Date: Fri, 15 Mar 2024 20:37:41 +0200 Message-ID: <86y1aj734a.fsf@gnu.org> References: <86wmq39av4.fsf@gnu.org> <864jd78r80.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34678"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael.albinus@gmx.de, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 15 19:38:34 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rlCRu-0008o3-NO for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Mar 2024 19:38:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlCRB-0001Q1-3a; Fri, 15 Mar 2024 14:37:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlCR8-0001Pf-Rq for emacs-devel@gnu.org; Fri, 15 Mar 2024 14:37:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlCR7-0001Bn-Ny; Fri, 15 Mar 2024 14:37:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RfZoYjCPfHMLdBTjVdcd+US+YGoKlvJGkEQXNPrVP2k=; b=ABz6uyFeWsCS BK1brZiY15NVwjUPZ51E0v4pyzaR+jELFxfP0cOVIGjfTk53l4RvdLfGhsavRPYP52cPcWRN1WLrD TcOZ5YAMRPzNq/24l/JSbZ8FSZmX6O/5t4ocVN1LKmxGaW2VlECpawmrGcO+X5IAMhiE1VHQyWgpZ awQBZaCoYV3UUgJ25Wplw3ZxDbVxzznIHnZoLll74gkEHU+9/MF/D+K/nAPn5EiVXH+SnefQcnkOR 5iH6uC8Afoc/85UaVd9J/oblNU3tPD2mTml44ig4gD6PrVf7+rA4mINwjhKrgLaOAcnRzMfiW7I8S MVb0w1jnzb3BynshA3K7jg==; In-Reply-To: (message from Stefan Monnier on Fri, 15 Mar 2024 13:55:34 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317091 Archived-At: > From: Stefan Monnier > Cc: michael.albinus@gmx.de, emacs-devel@gnu.org > Date: Fri, 15 Mar 2024 13:55:34 -0400 > > > In end of data: > > simple.el:10907:4: Warning: the function `define-icon' might not be defined at runtime. > > simple.el:10883:19: Warning: the function `icon-string' might not be defined at runtime. > > Makefile:289: recipe for target `../lisp/simple.elc' failed > > Ah, right: the code as written only works if there's a warning earlier, > because it uses `define-icon` inside a function and that macro is > defined in `icons` and is not autoloaded, so the only reason it > currently works is that `display-warning` loads `icons`: as soon as we > fix the warning, the core problem shows up. > > The hideous patch below should result in working code without warnings, > but I hope we can find a better solution (e.g. one that lets us move > the two `define-icon`s to the toplevel of some file rather than being > inside a function). Yes, the warnings are gone with this patch. I do hope we can find a cleaner solution. How about loading icons when compiling? Or adding an autoload form which states that the variable is in icons.el?