Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of passwords

[Eli Zaretskii <eliz@gnu.org>]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: michael.albinus@gmx.de,  emacs-devel@gnu.org
> Date: Fri, 15 Mar 2024 13:55:34 -0400
> 
> >   In end of data:
> >   simple.el:10907:4: Warning: the function `define-icon' might not be defined at runtime.
> >   simple.el:10883:19: Warning: the function `icon-string' might not be defined at runtime.
> >   Makefile:289: recipe for target `../lisp/simple.elc' failed
> 
> Ah, right: the code as written only works if there's a warning earlier,
> because it uses `define-icon` inside a function and that macro is
> defined in `icons` and is not autoloaded, so the only reason it
> currently works is that `display-warning` loads `icons`: as soon as we
> fix the warning, the core problem shows up.
> 
> The hideous patch below should result in working code without warnings,
> but I hope we can find a better solution (e.g. one that lets us move
> the two `define-icon`s to the toplevel of some file rather than being
> inside a function).

Yes, the warnings are gone with this patch.

I do hope we can find a cleaner solution.

How about loading icons when compiling?  Or adding an autoload form
which states that the variable is in icons.el?