From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS: Win64 testers? Date: Sat, 07 Sep 2024 11:19:56 +0300 Message-ID: <86y143yixf.fsf@gnu.org> References: <87bk1k8mzd.fsf@protonmail.com> <861q2gs8xu.fsf@gnu.org> <877cc88j4p.fsf@protonmail.com> <86seuvre6x.fsf@gnu.org> <8734mv8yb6.fsf@protonmail.com> <87wmk54yk5.fsf@protonmail.com> <86r0a3ahm9.fsf@gnu.org> <86plpnacsd.fsf@gnu.org> <86jzfva8k3.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7854"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sebastian@sebasmonia.com, pipcet@protonmail.com, emacs-devel@gnu.org, yantar92@posteo.net To: Kien Nguyen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 07 10:21:18 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smqh4-0001p7-69 for ged-emacs-devel@m.gmane-mx.org; Sat, 07 Sep 2024 10:21:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smqgF-0005qf-SQ; Sat, 07 Sep 2024 04:20:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smqgE-0005qX-Ue for emacs-devel@gnu.org; Sat, 07 Sep 2024 04:20:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smqgD-0004Qx-K3; Sat, 07 Sep 2024 04:20:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Pf8wsEcUfXNLP7EeWstaNpwEj5TwhpwotW8241N+Bfw=; b=saly6e3Mg33h fCYwy/M9YpiyoqGX7Hl3WyWMWwIR6cvHZLIPtNb1tReDIBavCEXpSYsNQtOhrWTpGm9m9kTOR0reP 0wKsFYC+NTG6tyOMwUZyAOr3gEboBHGGOTlXu4v/87wjCIrYowuVC0O8TdLwPF0Jk/WIhzcpPvupA Yq6Dxh8hHqnDlPdm4Q249bd+ddW740rp7HCuCL48p2EVD7tOIwbHbgS1O45qxmNNf9kH0m8bbjKSQ JDn6u7nsk1lxciUQU4onx9LOf626qXaoMrxh+C2C82/7CshfX+bJ1atvzzhNQR1oefQgPXdv26SaG JBpzTchw1QBMmw0M1YgDQA==; In-Reply-To: (message from Kien Nguyen on Sun, 1 Sep 2024 11:54:04 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323485 Archived-At: > From: Kien Nguyen > Date: Sun, 1 Sep 2024 11:54:04 -0700 > Cc: sebastian@sebasmonia.com, pipcet@protonmail.com, emacs-devel@gnu.org, > yantar92@posteo.net > > > Does the alternative change below solve your problem when attaching to > > Emacs?? > > Sorry, I didn't notice this email before answering the other one. :) > > Yes, that would also solve my issue. The `if` check should be changed to > a `while` loop, as `remove_w32_kbdhook` will just decrease the reference > count if there's still more than one reference to the `kbdhook`. Thanks, I made that change and installed the result on the master branch.