From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master a4014c058b5 1/2: Add new `header-line-active' and `header-line-inactive' faces Date: Wed, 04 Dec 2024 15:45:01 +0200 Message-ID: <86y10vzhnm.fsf@gnu.org> References: <173176622414.2711857.390137952858045982@vcs3.savannah.gnu.org> <20241116141026.7FC37462447@vcs3.savannah.gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10366"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, trevor.m.murphy@gmail.com To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 04 14:46:16 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIphn-0002RJ-Jc for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Dec 2024 14:46:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIphA-0004jG-KP; Wed, 04 Dec 2024 08:45:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIph0-0004hI-Jj for emacs-devel@gnu.org; Wed, 04 Dec 2024 08:45:27 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIpgz-0007J4-Jb; Wed, 04 Dec 2024 08:45:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vMCXB9W6i9wfwNDk2EessTty5OC7Qsc/690SfsenOb0=; b=hnq0ftq5ndX5 KMVsW7D/mQ7HEvZLZspHJQSXAX2QZtVSqbOz6wYB7W0PKajPSNd7Wv+ghWW7Jq8upUV2kBM8Yzkex jBgPNduHGyKodqc7vBvm03/nhSX/cOxEda8OLAFnCUwbVcNCW0lqKy0z70dpQ5G4WxeWc3+teRWfq ugG7tFmwctdfkoopA+0CmHcJYMP19LXvY/8yfc8smZOSJumBaXTTuW68k9mJ172Ph4Ia/OC7tSc6S v0YI8N+/hzv0k4rhS3pnxnFyEHJonGtmf52kMGZRZOWsLkmHfp6pW/t52+f/gb6PcSiNUPJ7/Nz6l LxeLvBHfKiaYAYjRYMqvyg==; In-Reply-To: (message from Eshel Yaron on Wed, 04 Dec 2024 10:47:18 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326028 Archived-At: > From: Eshel Yaron > Cc: Trevor Murphy > Date: Wed, 04 Dec 2024 10:47:18 +0100 > > > Add new `header-line-active' and `header-line-inactive' faces > > > > This is all intended to parallel the 'mode-line-active' and > > 'mode-line-inactive' distinction. > [...] > > This seems to introduce a regression, consider the following recipe: > > 1. emacs -Q > 2. In the scratch buffer, evaluate: > (setq header-line-format "foobar") > (face-remap-add-relative 'header-line 'highlight) > 3. Type C-x C-M-= or something similar to force updating the header > line. The header line in the scratch buffer now shows "foobar" and > uses the highlight face, as expected > 4. Type C-x 4 b new RET to switch to another buffer in another window > 5. In the new buffer evaluate (setq header-line-format "foobar") > 6. Observe that the header line in the new buffer is also using the > highlight face. That's unexpected! > 7. Type C-x C-M-= while the new buffer is current > 8. Observe that the header lines in both windows no longer have the > highlight face. That's unexpected! > > Before, remapping the header-line face with face-remap-add-relative > would only affect the current buffer, as expected. Now it seems like > the face remapping "leaks" between buffers/windows somehow... Thanks, this is being discussed in bug#73862. I will respond there. Please in the future report bugs to the bug tracker, even if the bug is in the development version of Emacs.