Warning in lib/malloc.c

Warning in lib/malloc.c

[Eli Zaretskii]

Recent update from Gnulib causes the following compilation warning
when building with MinGW:

  malloc.c:32:1: warning: no previous prototype for 'rpl_malloc' [-Wmissing-prototypes]
     32 | rpl_malloc (size_t n)
	| ^~~~~~~~~~

I'm guessing that this is because nt/gnulib-cfg.mk does

  OMIT_GNULIB_MODULE_malloc-posix = true
  OMIT_GNULIB_MODULE_realloc-gnu = true
  OMIT_GNULIB_MODULE_realloc-posix = true

and thus does not include (and probably doesn't generate) some Gnulib
header.  I also think that the MinGW build should not compile
malloc.c, as I've seen no callers of rpl_malloc.  So maybe
nt/gnulib-cfg.mk should also do

  OMIT_GNULIB_MODULE_malloc-gnu = true

?  If you agree, I will make that change.

Thanks.

Re: Warning in lib/malloc.c

[Paul Eggert]

On 2024-12-18 05:30, Eli Zaretskii wrote:
> So maybe
> nt/gnulib-cfg.mk should also do
> 
>    OMIT_GNULIB_MODULE_malloc-gnu = true

Yes, that sounds right.

Re: Warning in lib/malloc.c

[Eli Zaretskii]

> Date: Wed, 18 Dec 2024 09:48:20 -0800
> Cc: emacs-devel@gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> 
> On 2024-12-18 05:30, Eli Zaretskii wrote:
> > So maybe
> > nt/gnulib-cfg.mk should also do
> > 
> >    OMIT_GNULIB_MODULE_malloc-gnu = true
> 
> Yes, that sounds right.

Thanks.  It turned out to be more complicated than that, but now done.