From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Making decoded-times and calendar dates compatible? Date: Sat, 21 Dec 2024 12:45:32 +0200 Message-ID: <86y10971rn.fsf@gnu.org> References: <87seqy5qr8.fsf@ohm.mail-host-address-is-not-set> <8734isrign.fsf@ohm.mail-host-address-is-not-set> <87frmno0l1.fsf@recursewithless.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18932"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rms@gnu.org, emacs-devel@gnu.org To: Richard Lawrence Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 21 11:46:40 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOx0J-0004mA-7n for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Dec 2024 11:46:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOwzR-00011q-Nl; Sat, 21 Dec 2024 05:45:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOwzP-00011b-0Y for emacs-devel@gnu.org; Sat, 21 Dec 2024 05:45:43 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOwzO-0003Xi-Az; Sat, 21 Dec 2024 05:45:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QEbny+Fw5cCu/TzWXllExSEmGQD5kFV2uERfwGDw/nQ=; b=eTEkvz3NSha8 esMZv4usQeCx5C2VgjybcQUCJRQr+r1Mpb5UmVqXPNIlwdo2Jl6O7Q26TaLiXfGY+0s2NQFbff+oQ YZof+3+ZXlAzFhUo1BU/TY5ak0h9437rml2N2tnYqjt6mqOhsuUe2ladUZJOzP7L202XyANyjKF3l 8L9DaFVu2GaxB/gQ+C584efzKQwUhdSPiHGqTCXwxd3vN/feJBxr/qy4FpoD6bX21abQSYH+fuWqV vepkUYURW33BZVQIbIIEFrxeqpCyxMfNmB/C1nJqnBQMMhBldvnwMPVh1ieze/q0YwXXGAirom/Jj LIJEUJhGymNtzsZcEG1gnA==; In-Reply-To: <87frmno0l1.fsf@recursewithless.net> (message from Richard Lawrence on Mon, 16 Dec 2024 21:05:30 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326817 Archived-At: > From: Richard Lawrence > Cc: emacs-devel@gnu.org > Date: Mon, 16 Dec 2024 21:05:30 +0100 > > Richard Stallman writes: > > The docstrings of the functions > > > > > calendar-extract-year > > > calendar-extract-month > > > calendar-extract-day > > > > > are where the (MONTH DAY YEAR) format is mentioned. > > > > Would someoe like to add some comments at the start of the file > > documenging this data structure? > > Attached is a patch which adds such a comment, based on my previous > message; let me know if I should open a bug report for this. In general, yes. But we can make exceptions. I've now installed your change on the emacs-30 release branch. > For now I take it that it's better not to touch the calendar code? I > don't think there is any constructor function for dates, or at least, I > see that throughout the calendar code, there are many uses of "(list > month day year)" to construct dates, so there might be a lot of code to > fix if we change the representation, and it might be hard to be sure > we've made all the necessary changes. Anyway, this is more work than I > want to do at the moment, though I'm willing to take a stab at it > eventually if others here think it would be worthwhile. I think you are right.