unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Richard Lawrence <rwl@recursewithless.net>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: [PATCH] Re: Making decoded-times and calendar dates compatible?
Date: Sat, 21 Dec 2024 12:45:32 +0200	[thread overview]
Message-ID: <86y10971rn.fsf@gnu.org> (raw)
In-Reply-To: <87frmno0l1.fsf@recursewithless.net> (message from Richard Lawrence on Mon, 16 Dec 2024 21:05:30 +0100)

> From: Richard Lawrence <rwl@recursewithless.net>
> Cc: emacs-devel@gnu.org
> Date: Mon, 16 Dec 2024 21:05:30 +0100
> 
> Richard Stallman <rms@gnu.org> writes:
> >   The docstrings of the functions
> >
> >   > calendar-extract-year
> >   > calendar-extract-month
> >   > calendar-extract-day
> >
> >   > are where the (MONTH DAY YEAR) format is mentioned.
> >
> > Would someoe like to add some comments at the start of the file
> > documenging this data structure?
> 
> Attached is a patch which adds such a comment, based on my previous
> message; let me know if I should open a bug report for this.

In general, yes.  But we can make exceptions.

I've now installed your change on the emacs-30 release branch.

> For now I take it that it's better not to touch the calendar code? I
> don't think there is any constructor function for dates, or at least, I
> see that throughout the calendar code, there are many uses of "(list
> month day year)" to construct dates, so there might be a lot of code to
> fix if we change the representation, and it might be hard to be sure
> we've made all the necessary changes. Anyway, this is more work than I
> want to do at the moment, though I'm willing to take a stab at it
> eventually if others here think it would be worthwhile.

I think you are right.



      parent reply	other threads:[~2024-12-21 10:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-08 12:00 Making decoded-times and calendar dates compatible? Richard Lawrence
2024-12-11  4:33 ` Richard Stallman
2024-12-12 16:09   ` Richard Lawrence
2024-12-16  4:14     ` Richard Stallman
2024-12-16 20:05       ` [PATCH] " Richard Lawrence
2024-12-17  4:39         ` Richard Stallman
2024-12-17 12:41           ` Eli Zaretskii
2024-12-19  8:51             ` Richard Lawrence
2024-12-17  4:39         ` Richard Stallman
2024-12-21 10:45         ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y10971rn.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    --cc=rwl@recursewithless.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).