From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Richard Kim Newsgroups: gmane.emacs.devel Subject: Re: Emacs master build failing on RHEL 6.8 [image.c] Date: Sat, 08 Jun 2019 07:24:34 -0700 Message-ID: <86wohw5f4t.fsf@gmail.com> References: Reply-To: emacs18@gmail.com Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26035"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.50 (gnu/linux) To: emacs-devel@gnu.org Cancel-Lock: sha1:rf8WgEOLCyOYZknGggq3IzR1d+0= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 16 17:56:28 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n98pP-0006XI-Mc for ged-emacs-devel@m.gmane-mx.org; Sun, 16 Jan 2022 17:56:27 +0100 Original-Received: from localhost ([::1]:54028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n98pO-00045C-7z for ged-emacs-devel@m.gmane-mx.org; Sun, 16 Jan 2022 11:56:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n98o5-0003NT-QL for emacs-devel@gnu.org; Sun, 16 Jan 2022 11:55:05 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:33998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n98o4-0005Bd-CI for emacs-devel@gnu.org; Sun, 16 Jan 2022 11:55:05 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1n98o2-0004pC-4j for emacs-devel@gnu.org; Sun, 16 Jan 2022 17:55:02 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 42 X-Spam_score: 4.2 X-Spam_bar: ++++ X-Spam_report: (4.2 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_96_XX=3.405, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284837 Archived-At: Kaushal Modi writes: > Hello Paul, > > On Tue, Jun 4, 2019 at 3:17 PM Paul Eggert wrote: > > This looks like some other glitch in your build process, something you > should fix but unrelated to the GifErrorString problem. > > You are right! I reverted to the old commit where I was last able to build and I am seeing the same error. > > I need to now figure out what change on my side could have caused this. Sorry for this false alarm. > > I'll update here if I figure this out. Actually I too ran into compile failure on Red Hat 6.6. The root cause was that the change shown below added code referring to LIBRSVG_CHECK_VERSION macro which is not defined for me. I have been using the same build script to build emacs on Red Hat 6.6 for a long time for both master and emacs-26 branches. This is the first time that emacs build failed for me on RH 6 in many months if not over a year. -------------------------------------------------------------------------------- Author: Paul Eggert AuthorDate: Thu May 30 15:06:39 2019 -0700 Commit: Paul Eggert CommitDate: Thu May 30 15:29:50 2019 -0700 Parent: d93f4bda7a Simplify xd_signature to pacify GCC 9 Contained: emacs-26 master Follows: emacs-26.2 (78) Pacify librsvg 2.45.1 and later * src/image.c (svg_load_image): Pacify librsvg 2.45.1 and later, and add a FIXME comment about the deprecated librsvg functions. Backport from master. 1 file changed, 15 insertions(+) src/image.c | 15 +++++++++++++++ modified src/image.c @@ -9306,6 +9306,17 @@ svg_load_image (struct frame *f, struct image *img, char *contents, if (filename) rsvg_handle_set_base_uri(rsvg_handle, filename); + /* Suppress GCC deprecation warnings starting in librsvg 2.45.1 for + rsvg_handle_write and rsvg_handle_close. FIXME: Use functions + like rsvg_handle_new_from_gfile_sync on newer librsvg versions, + and remove this hack. */ + #if GNUC_PREREQ (4, 6, 0) + #pragma GCC diagnostic push + #endif + #if LIBRSVG_CHECK_VERSION (2, 45, 1) && GNUC_PREREQ (4, 2, 0) + #pragma GCC diagnostic ignored "-Wdeprecated-declarations" + #endif + /* Parse the contents argument and fill in the rsvg_handle. */ rsvg_handle_write (rsvg_handle, (unsigned char *) contents, size, &err); if (err) goto rsvg_error; @@ -9315,6 +9326,10 @@ svg_load_image (struct frame *f, struct image *img, char *contents, rsvg_handle_close (rsvg_handle, &err); if (err) goto rsvg_error; + #if GNUC_PREREQ (4, 6, 0) + #pragma GCC diagnostic pop + #endif + rsvg_handle_get_dimensions (rsvg_handle, &dimension_data); if (! check_image_size (f, dimension_data.width, dimension_data.height)) {