From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: change pcomplete/make to include targets in included files Date: Mon, 16 Sep 2019 16:33:29 -0700 Message-ID: <86woe7rf3q.fsf@stephe-leake.org> References: <86muf7p5w7.fsf@stephe-leake.org> <86y2ypnxsv.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="187958"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (windows-nt) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 17 01:34:26 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iA0Vl-000mm7-KD for ged-emacs-devel@m.gmane.org; Tue, 17 Sep 2019 01:34:26 +0200 Original-Received: from localhost ([::1]:40728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iA0Vj-0002Mp-Rg for ged-emacs-devel@m.gmane.org; Mon, 16 Sep 2019 19:34:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50184) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iA0Uv-0002MR-Pk for emacs-devel@gnu.org; Mon, 16 Sep 2019 19:33:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iA0Uu-0002PH-IO for emacs-devel@gnu.org; Mon, 16 Sep 2019 19:33:33 -0400 Original-Received: from gateway31.websitewelcome.com ([192.185.143.51]:44527) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iA0Uu-0002P6-CI for emacs-devel@gnu.org; Mon, 16 Sep 2019 19:33:32 -0400 Original-Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 04D07D53F5 for ; Mon, 16 Sep 2019 18:33:31 -0500 (CDT) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with SMTP id A0UsiFtZg4FKpA0UsiGMij; Mon, 16 Sep 2019 18:33:31 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:To:From:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YY42AqHGfDO2FMikFbtY+kbeuW61zNMZQL26vPMF2Dg=; b=Z4w9I5SR5zgk8fEFrUW/8onfc lS1DV0VeYzsMSRCa0SdX0y1niUduEiJ3ZmKMimDkqSb9kop+a2QMEXotnalwFm0S3uiseMUJ+AscW ngPPjUiNnO4tEKL6StKQp3WHsalPQn/V3L0sDhiBHPwL9HF5BTmX2FY0IdPIOeHe+rRJVNIC6EOXP t+CJ3tKfRsVaKq9+u/0U8YQTJLRH1Ntx7z4i1+JKY7xmpJ5xVUF7tSJbcJaQG/gxleJwzqgxVkTdl CmqvNuAdmEnjo505smbLioJJQDj3VNzxCeiwQHGldD/4NMOay+E2WNdpl9g2Q+jesXQPQmIxJlTLd K2QOz49ZQ==; Original-Received: from [76.77.182.20] (port=49815 helo=Takver4) by host2007.hostmonster.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iA0Us-003ncy-DO for emacs-devel@gnu.org; Mon, 16 Sep 2019 17:33:30 -0600 In-Reply-To: (Stefan Monnier's message of "Sun, 15 Sep 2019 16:56:00 -0400") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1iA0Us-003ncy-DO X-Source-Sender: (Takver4) [76.77.182.20]:49815 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 3 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 192.185.143.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240095 Archived-At: Stefan Monnier writes: >> That doesn't seem to work. The list ('rules' in >> pcmp-gnu-with-file-buffer) is initially nil, which means it is not >> passed by reference, so it is never updated. Unless there is some way to >> force pass by reference? (I think that requires a macro?) > > I definitely don't want to pass anything by reference (I like things to > be immutable). I meant you should be doing > > (setq targets (pcmpl-gnu-make-all-targets ... targets)) > > instead of > > (setq targets (append (pcmpl-gnu-make-all-targets ...) > targets)) > > it's a standard coding style in functional programming (except > using recursion rather than while+setq, of course). Ah; you can do 'push' on the 'targets' arg (whether nil or otherwise), then return it. That makes sense. -- -- Stephe