From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Changing line widths in the Emacs source code Date: Sun, 13 Sep 2020 18:23:40 +0100 Message-ID: <86wo0xlher.fsf@gmail.com> References: <87tuw1x016.fsf@gnus.org> <877dsxlo0h.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2542"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (windows-nt) To: emacs-devel@gnu.org Cancel-Lock: sha1:+bvIpiaChMkKSd8x1pgj6vAvAx0= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 13 19:24:23 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHVjj-0000ZQ-Gj for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 19:24:23 +0200 Original-Received: from localhost ([::1]:59264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHVji-0008Ec-JY for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 13:24:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHVjC-0007en-N9 for emacs-devel@gnu.org; Sun, 13 Sep 2020 13:23:50 -0400 Original-Received: from static.214.254.202.116.clients.your-server.de ([116.202.254.214]:49732 helo=ciao.gmane.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHVjB-0002Gn-E6 for emacs-devel@gnu.org; Sun, 13 Sep 2020 13:23:50 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1kHVj8-000ATp-Nc for emacs-devel@gnu.org; Sun, 13 Sep 2020 19:23:46 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/13 09:46:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255532 Archived-At: On Sun 13 Sep 2020, Lars Ingebrigtsen wrote: > Daniel Martín writes: > >> I don't agree with this suggestion, at least as it is written. If the >> existing code won't change, then we will have parts of the codebase with >> a different style than others. The goal of having a code style is not >> much about the individual decisions, but about consistency. > > Nope -- in the Emacs tree, we're all about not making needless stylistic > changes, really. That's why we don't make white space changes, and we > don't change one-form `if' statements into `when' across the board. And this is exactly why changing line length is a bad idea. Any code which requires overlong lines is usually clearer and more maintainable if rewritten to use shorter lines, and helper routines if needed. AndyM