From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 39e3fce0d5e0: 'read-passwd' can toggle the visibility of
 passwords
Date: Fri, 15 Mar 2024 10:07:27 +0200
Message-ID: <86wmq39av4.fsf@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="8840"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Michael Albinus <michael.albinus@gmx.de>,
 Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 15 09:08:23 2024
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1rl2c3-00024v-PY
	for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Mar 2024 09:08:23 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1rl2bF-00071i-It; Fri, 15 Mar 2024 04:07:33 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1rl2bD-0006vZ-VN
 for emacs-devel@gnu.org; Fri, 15 Mar 2024 04:07:32 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1rl2bC-0003tc-Tr; Fri, 15 Mar 2024 04:07:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to:
 references; bh=W0yXdROF3svp/hVYs7lK4gZ4OMDtIeWdYkb68mdgLcA=; b=D5UPjZhy/EJCor
 3HTfful3/TpwkTQ/2Dk7reLuFh76De/njqvQ0RGaWtRXYU6wODyEk495pBE2TlbRYNMxAtGqO3ra8
 KNHXXP/pdpFUn3LF2czlh98sPg0/Y/z+7XT0rB0sJCbx/odqRzxPQ0VyfBP7934YSa+nN/bdMdM05
 Y8qlgirjF3Fd6Mgg/wixW5en33C6s9M6ulVWop1AbJ0DQsRLzKDLr2UJFDoXi0W4hT62Ix11rj7jC
 0KU7LC1sMTzb2tGqvzfTjN+bjsjZ3ln1S9aNiV0AHYDZKALOljdhavK7F2EwbEONy9Oyu+MPX+Wd9
 d5ogPP4QTF2+jwbgOH1Q==;
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:317053
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/317053>

Michael,

The changes in the above commit cause the following warning when
compiling simple.el:

  In read-passwd-toggle-visibility:
  simple.el:10880:18: Warning: reference to free variable `icon-preference'

The usual knee-jerk reaction of adding a defvar for the variable
didn't help (in fact, it made the situation worse), so please find a
way of shutting up this warning somehow.  I'm guessing this is due to
a somewhat unusual method of adding icons dependency to simple.el,
which (rightfully) attempts to avoid preloading icons.el, but I'm not
sure how to fix the warning in this situation.  Perhaps Stefan could
have some ideas?