From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Introducing 'safety' compilation parameter Date: Tue, 14 May 2024 09:11:38 +0300 Message-ID: <86wmnwx6qt.fsf@gnu.org> References: <864jb1y1uu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16555"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org, mattias.engdegard@gmail.com, stefankangas@gmail.com To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 14 08:12:54 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s6lPC-00045X-9Q for ged-emacs-devel@m.gmane-mx.org; Tue, 14 May 2024 08:12:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6lOZ-0003tE-0x; Tue, 14 May 2024 02:12:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6lO5-0003nV-FP for emacs-devel@gnu.org; Tue, 14 May 2024 02:11:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6lO4-0001kL-NT; Tue, 14 May 2024 02:11:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Af7JaER2euDcpM/1XaMNDDQ9PaqT+fJWEeN9b7Zz+/Y=; b=F/3RkuVy6d28oSgsOvWj MA/MbZbAdRO6N3gYYPfSCSBPd+YHYGSydhNcVuJWFjNJJW1VBwHC327g6HAst2sS707ijTn+kATkE 20uz7XzwWMIbll2XaALXAaygwhoo6bIk7g3AjT0rdzizZ8iPxIDPeZ4BHSLp3nCCNltuEnlPpPwgw 3uKvQJnxlIfFd1um4rjTV1PQBefamgmjk8pYqhmRk6TJzVQibn4A5/2kNZ/RCV39WLTGZ3ujo1dJ7 FZjQHWPWJPfZrdRFclaMRox6M00uoc4wOp72z2lhjQeqeJxjhTD9kV5U9Eo5x60fULoZLz+fb0NvK k2nrN2mhHaKvXw==; In-Reply-To: (message from Andrea Corallo on Mon, 13 May 2024 17:12:15 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319215 Archived-At: > From: Andrea Corallo > Cc: Stefan Monnier , emacs-devel@gnu.org, > mattias.engdegard@gmail.com, stefankangas@gmail.com > Date: Mon, 13 May 2024 17:12:15 -0400 > > Eli Zaretskii writes: > > >> > Okay I pushed scratch/comp-safety2 changing the knob name to > >> > 'compilation-safety' and gating the dangerous optimizations as > >> > discussed. > >> > >> Thanks. LGTM now (I'm still not sure we need both "safety" and "speed" > >> controls, but we may as well follow CL's lead). > > > > Agreed. Andrea, feel free to land this on master, and thanks. > > Done now. As usual feel free to round any edge if you spot it 🙏 Done.