From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 6aa5068ac71 1/3: Improve treatment of touch screen input by rmc and its callers Date: Thu, 27 Jun 2024 10:45:43 +0300 Message-ID: <86wmma6d7c.fsf@gnu.org> References: <171861761168.16246.1990246088317606554@vcs2.savannah.gnu.org> <20240617094652.69EE0C1FB5F@vcs2.savannah.gnu.org> <878qz141ux.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22384"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: luangruo@yahoo.com, Arash Esbati Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 27 09:45:56 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMjpL-0005cC-Uu for ged-emacs-devel@m.gmane-mx.org; Thu, 27 Jun 2024 09:45:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMjpE-0008Jw-ID; Thu, 27 Jun 2024 03:45:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMjpC-0008JU-HC for emacs-devel@gnu.org; Thu, 27 Jun 2024 03:45:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMjpC-0003UM-8P; Thu, 27 Jun 2024 03:45:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nfhbcMgDYJm2/mbosHbJ92L+eYYQm3NON7TO3mq3O9o=; b=TDYt1Q4kq3Kv NQL+A+tuEdjQqgApoK+dmz63WPjph/NogjnFGGxjoxQ9rtm/XuR0ktpYeLFrBa1qaKlB+V4dW8Y2P VI90gEEalRKG2o0YKpsJ51U0R1tlgSIrTnHicycnuXoXKfxnpZqCUsv2vSKrKWlvcVMepe+5S81vX Z+PFx2x/qp0hTXlFZ6S49rWpr6Lj5LMgTzDuHiPemdI2vVAXnvEK0U98j7Ll79d9vKVi9i0MzOTCE H1JsQVhW2o+QNworM2+Z20A0TpqG4CdQSxMLvgc/awfzDoyt3RKl3vnF2T5g2uUViHKbCAgNObIk9 NcgoyhEUOWYl4nJEiuEaIQ==; In-Reply-To: (message from Arash Esbati on Wed, 19 Jun 2024 13:42:17 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320755 Archived-At: > From: Arash Esbati > Cc: emacs-devel@gnu.org > Date: Wed, 19 Jun 2024 13:42:17 +0200 > > Po Lu writes: > > > OK, what if you replace in: > > > >>> + ;; Respond to scroll and pinch events as if RMC were > >>> + ;; not in progress. > >>> + ((eq (car-safe command) 'touchscreen-scroll) > >>> + (funcall #'touch-screen-scroll command)) > >>> + ((eq (car-safe command) 'touchscreen-pinch) > >>> + (funcall #'touch-screen-pinch command)) > > > > #'touch-screen-scroll and #'touch-screen-pinch with 'touch-screen-scroll > > and 'touch-screen-pinch? > > "Hiding" them from the compiler didn't work, the following change did: > > --8<---------------cut here---------------start------------->8--- > diff --git a/lisp/emacs-lisp/rmc.el b/lisp/emacs-lisp/rmc.el > index 883f8bf187f..a9142a8b46b 100644 > --- a/lisp/emacs-lisp/rmc.el > +++ b/lisp/emacs-lisp/rmc.el > @@ -179,6 +179,9 @@ read-multiple-choice > (read-multiple-choice--short-answers > prompt choices help-string show-help))) > > +(declare-function touch-screen-scroll "touch-screen" (event)) > +(declare-function touch-screen-pinch "touch-screen" (event)) > + > (defun read-multiple-choice--short-answers (prompt choices help-string show-help) > (let* ((dialog-p (use-dialog-box-p)) > (prompt-choices > --8<---------------cut here---------------end--------------->8--- Ping!