From: Eli Zaretskii <eliz@gnu.org>
To: luangruo@yahoo.com, Arash Esbati <arash@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 6aa5068ac71 1/3: Improve treatment of touch screen input by rmc and its callers
Date: Thu, 27 Jun 2024 10:45:43 +0300 [thread overview]
Message-ID: <86wmma6d7c.fsf@gnu.org> (raw)
In-Reply-To: <m2bk3x40rq.fsf@macmutant.fritz.box> (message from Arash Esbati on Wed, 19 Jun 2024 13:42:17 +0200)
> From: Arash Esbati <arash@gnu.org>
> Cc: emacs-devel@gnu.org
> Date: Wed, 19 Jun 2024 13:42:17 +0200
>
> Po Lu <luangruo@yahoo.com> writes:
>
> > OK, what if you replace in:
> >
> >>> + ;; Respond to scroll and pinch events as if RMC were
> >>> + ;; not in progress.
> >>> + ((eq (car-safe command) 'touchscreen-scroll)
> >>> + (funcall #'touch-screen-scroll command))
> >>> + ((eq (car-safe command) 'touchscreen-pinch)
> >>> + (funcall #'touch-screen-pinch command))
> >
> > #'touch-screen-scroll and #'touch-screen-pinch with 'touch-screen-scroll
> > and 'touch-screen-pinch?
>
> "Hiding" them from the compiler didn't work, the following change did:
>
> --8<---------------cut here---------------start------------->8---
> diff --git a/lisp/emacs-lisp/rmc.el b/lisp/emacs-lisp/rmc.el
> index 883f8bf187f..a9142a8b46b 100644
> --- a/lisp/emacs-lisp/rmc.el
> +++ b/lisp/emacs-lisp/rmc.el
> @@ -179,6 +179,9 @@ read-multiple-choice
> (read-multiple-choice--short-answers
> prompt choices help-string show-help)))
>
> +(declare-function touch-screen-scroll "touch-screen" (event))
> +(declare-function touch-screen-pinch "touch-screen" (event))
> +
> (defun read-multiple-choice--short-answers (prompt choices help-string show-help)
> (let* ((dialog-p (use-dialog-box-p))
> (prompt-choices
> --8<---------------cut here---------------end--------------->8---
Ping!
prev parent reply other threads:[~2024-06-27 7:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171861761168.16246.1990246088317606554@vcs2.savannah.gnu.org>
[not found] ` <20240617094652.69EE0C1FB5F@vcs2.savannah.gnu.org>
2024-06-19 10:36 ` master 6aa5068ac71 1/3: Improve treatment of touch screen input by rmc and its callers Arash Esbati
2024-06-19 11:18 ` Po Lu
2024-06-19 11:42 ` Arash Esbati
2024-06-27 7:45 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wmma6d7c.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=arash@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).