From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [scratch/igc] 985247b6bee crash on Linux, KDE, Wayland Date: Thu, 05 Sep 2024 17:33:53 +0300 Message-ID: <86wmjq2mr2.fsf@gnu.org> References: <8734mezkgo.fsf@gmail.com> <87plpis6ff.fsf@protonmail.com> <87bk124aip.fsf@gmail.com> <87h6aus5yz.fsf@protonmail.com> <87y1461frv.fsf@gmail.com> <864j6u47g4.fsf@gnu.org> <8634me447j.fsf@gnu.org> <861q1y437s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37994"; mail-complaints-to="usenet@ciao.gmane.io" Cc: execvy@gmail.com, pipcet@protonmail.com, emacs-devel@gnu.org To: Gerd =?utf-8?Q?M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 05 16:35:02 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smDZd-0009gu-OH for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Sep 2024 16:35:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smDYs-0006u3-TZ; Thu, 05 Sep 2024 10:34:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smDYn-0006kR-At for emacs-devel@gnu.org; Thu, 05 Sep 2024 10:34:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smDYm-0003Pc-Sk; Thu, 05 Sep 2024 10:34:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=NEgMt8ub/2oYik3y+KHUrYPFr0cczTaOx3oaX1Emxkk=; b=O5DvIZO2ZKJh7Q3DAs1W PQ3Ki3JmSbbMjADR29BoeGlHvsU8SL20vXRg+E8MBS4U+bhqNItcPRQwj47FY9YXA0QjeFCvAeN8c ynBjigUnid5tLhtAPv1f3ULv7dl9lGlksHbYiwCdn1zgOmyMXhILn4GTT68GxhCjyQjhixZESqEXS SrXwW2Z20YMMvnqr8q+NqOU6TPhshWsBucxJakQ4Sz4JI/8/XDuc8BYeD9ouNhPAGEzENzufQLB8k RYSZPGin0AHUJAQSkgUz9s+lBm9Xv1HjGrYKNGpcT8fyTN7BJ5leaNSyjLAxiGXfXSvGz2ZqbGmoA zqgVmvxEtKFmCg==; In-Reply-To: (message from Gerd =?utf-8?Q?M=C3=B6llmann?= on Thu, 05 Sep 2024 15:57:50 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323409 Archived-At: > From: Gerd Möllmann > Cc: execvy@gmail.com, pipcet@protonmail.com, emacs-devel@gnu.org > Date: Thu, 05 Sep 2024 15:57:50 +0200 > > Eli Zaretskii writes: > > >> That means FRAME_OUTPUT_DATA can be null during the lifetime of a > >> frame. If that happens, we'll crash exactly in that way in the new code > >> for window frames. > > > > We never test for FRAME_OUTPUT_DATA being non-NULL in the code, so I > > don't think I understand why igc.c is different. > > Our scan functions can run at arbitrary times, including when > FRAME_OUTPUT_DATA is still null. OK, but if you look at the backtrace, you will see that in this case the scan functions were run from within code called by redisplay_internal, so I very much doubt that FRAME_OUTPUT_DATA was NULL in this case.