From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 69ec333eab0: Allow customizing partial-completion to be more like substring Date: Tue, 24 Sep 2024 14:22:16 +0300 Message-ID: <86wmj1e1p3.fsf@gnu.org> References: <172449136475.5211.17507793835510648935@vcs2.savannah.gnu.org> <20240824092245.2C0C9C41F06@vcs2.savannah.gnu.org> <87frqu6xbe.fsf@gmx.de> <865xrhca52.fsf@gnu.org> <86seu2hb9t.fsf@gnu.org> <86bk0h49dl.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19565"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Spencer Baugh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 24 13:23:05 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1st3dH-0004oN-IO for ged-emacs-devel@m.gmane-mx.org; Tue, 24 Sep 2024 13:23:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1st3cd-0005zd-2p; Tue, 24 Sep 2024 07:22:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1st3ca-0005zJ-1T for emacs-devel@gnu.org; Tue, 24 Sep 2024 07:22:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1st3cZ-0004Y7-0E; Tue, 24 Sep 2024 07:22:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JT4OW7ZCyjxqTAe+UvEC75eYHN+96RobLol1T31EI/g=; b=oYf1qSk7sD1U 8Zib9Y8roYbb2AmVYD07PfqLIjO/CZIwvLLR9swyTPdNEJFYcKPALltO9A6r9688LwdTP9N0xnKYR 6Fuh1Iz/jUX/KL3t9S1MdXg2ATOOVM2lDRazEXK8zWMGtwwngpG4xQokzJz/NvHLVLtxvDhD0aiRm NyHsCPMaxxRQkwvk4UJKYC3V9HlDv7ELjasv2rSP4r5c8VnHclC3kW07FfFWI0muHQD4tKfO62HUG hTlVGXsW78ePEXpOLJmNc5qd03Ml1QtZW09J6tkPcus6u7kXLAULMYZ0QKKQc8Le/a/NVr1fyf0y8 ROqCGax4BtOd3AvgPrHojw==; In-Reply-To: (message from Spencer Baugh on Mon, 23 Sep 2024 15:36:10 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324017 Archived-At: > From: Spencer Baugh > Cc: emacs-devel@gnu.org > Date: Mon, 23 Sep 2024 15:36:10 -0400 > > Eli Zaretskii writes: > >> Date: Sat, 14 Sep 2024 11:47:42 +0300 > >> From: Eli Zaretskii > >> Cc: emacs-devel@gnu.org > >> > >> > Date: Fri, 06 Sep 2024 13:23:19 -0400 > >> > From: Spencer Baugh via "Emacs development discussions." > >> > Eli Zaretskii writes: > >> > > Spencer, would you please take care of these gotchas? > >> > > >> > The attached patch does so. > >> > >> Thanks, installed. But the new single-or-list feature should be > >> documented in the ELisp manual. > > > > Ping! single-or-list is still undocumented, AFAICT. We should > > document it ASAP, as it is not good to have on the master branch > > features which are not reflected in the documentation. > > > > TIA > > I started writing documentation, but I came to the conclusion that most > users other than completion-styles should use the "group" widget > instead. And documenting single-or-list would encourage using it > instead of group, which I don't think is correct. > > Maybe this widget should just be moved to minibuffer.el? > > Alternatively, if there are any other customizable variables or values > in Emacs which are sometimes a single value, and sometimes a list, then > this widget would be useful for those. If we can think of any such > variables, then that would help justify the existence of single-or-list > (and I would convert their defcustoms to use single-or-list). That > would help in writing documentation about when exactly to use it. I'm not sure I understand: are you saying that your change to minibuffer.el can be rewritten to not use single-or-list? If so, I'm okay with that, and in that case we should simply remove single-or-list, until there are some users of it.