Emacs HEAD broken with XPM option in 1b492fa

[ashish.is@lostca.se (Ashish SHUKLA)]

[-- Attachment #1: Type: text/plain, Size: 4051 bytes --]

Hi,

I came across following build error in configure script, while building Emacs
git revision 1b492fa[1] on FreeBSD 11.1 amd64:

--8<---------------cut here---------------start------------->8---
checking tiffio.h presence... yes                                                                                              
checking for tiffio.h... yes                                                                                                                                                                                                     
checking for TIFFGetVersion in -ltiff... yes                                                          
checking gif_lib.h usability... yes                                                                      
checking gif_lib.h presence... yes                               
checking for gif_lib.h... yes                                                                                            
checking for GifMakeMapObject in -lgif... yes                          
configure: error: The following required libraries were not found:   
    libXpm                                                     
Maybe some development libraries/packages are missing?                                                                   
If you don't want to link with them give                                                                                 
    --with-xpm=no                                                                               
as options to configure                                                                            
--8<---------------cut here---------------end--------------->8---

Following is the configure line:

--8<---------------cut here---------------start------------->8---
./configure --with-gameuser=games:games --enable-acl --with-dbus --with-gnutls \
 --with-modules --with-threads --with-x --with-xml2 \
 --with-file-notification=kqueue --with-sound=oss --with-x-toolkit=gtk3 \
 --without-cairo --with-gif --with-jpeg --with-imagemagick --with-png \
 --with-rsvg --with-tiff --with-xpm --with-gconf --with-gsettings \
 --with-m17n-flt --with-libotf --with-toolkit-scroll-bars --with-xft --with-xim \
 --with-xwidgets --x-libraries=/usr/local/lib --x-includes=/usr/local/include \
 --prefix=/usr/local --localstatedir=/var --mandir=/usr/local/man \
 --disable-silent-rules --infodir=/usr/local/share/emacs/info/ \
 --build=amd64-portbld-freebsd11.1
--8<---------------cut here---------------end--------------->8---

The complete log is available from:
https://people.freebsd.org/~ashish/emacs-devel-1b492fa-config.log

It seems like in e88bbd22[2], author (cc'ed) typo-ed (s/X11/noX/):

--8<---------------cut here---------------start------------->8---
@@ -3372,18 +3365,18 @@ if test "${HAVE_X11}" = "yes"; then
     AC_CHECK_HEADER(X11/xpm.h,
       [AC_CHECK_LIB(Xpm, XpmReadFileToPixmap, HAVE_XPM=yes, , -lX11)])
     if test "${HAVE_XPM}" = "yes"; then
-      AC_MSG_CHECKING(for XpmReturnAllocPixels preprocessor define)
-      AC_EGREP_CPP(no_return_alloc_pixels,
-      [#include "X11/xpm.h"
+      AC_CACHE_CHECK([for XpmReturnAllocPixels preprocessor define],
+      [emacs_cv_cpp_xpm_return_alloc_pixels],
+      [AC_EGREP_CPP(no_return_alloc_pixels,
+      [#include "noX/xpm.h"
--8<---------------cut here---------------end--------------->8---

After updating the last line, configure script run finishes as expected
without any issue.

Happy to file a bug report, if it's reproducible elsewhere too.

Could you please look at this ?

References:
[1]  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1b492fa
[2]  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e88bbd22

Thanks!
-- 
Ashish SHUKLA

“…one of  the main causes  of the fall of  the Roman Empire  was that,
lacking zero,  they had no  way to indicate successful  termination of
their C programs.”
                                                          (Robert Firth)

Sent from my Emacs

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]