From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Why is custom--inhibit-theme-enable not t by default? Date: Sun, 17 Jun 2018 22:31:44 +0100 Message-ID: <86vaahgkvz.fsf@gmail.com> References: <10b7bd657091b074d8da1bf1ae35b1f4.squirrel@dancol.org> <83h8m8owp2.fsf@gnu.org> <48a7bd1277a18dd0a68d06cd8b022062.squirrel@dancol.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529270998 2081 195.159.176.226 (17 Jun 2018 21:29:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 17 Jun 2018 21:29:58 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 17 23:29:54 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUfFB-0000RT-RL for ged-emacs-devel@m.gmane.org; Sun, 17 Jun 2018 23:29:53 +0200 Original-Received: from localhost ([::1]:56489 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUfHI-0008AM-VZ for ged-emacs-devel@m.gmane.org; Sun, 17 Jun 2018 17:32:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59274) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUfHC-0008AH-M3 for emacs-devel@gnu.org; Sun, 17 Jun 2018 17:31:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUfH7-0002zQ-QC for emacs-devel@gnu.org; Sun, 17 Jun 2018 17:31:58 -0400 Original-Received: from [195.159.176.226] (port=41181 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fUfH7-0002z4-Is for emacs-devel@gnu.org; Sun, 17 Jun 2018 17:31:53 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fUfEx-0000GR-Uw for emacs-devel@gnu.org; Sun, 17 Jun 2018 23:29:39 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 39 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:ilzbuq5GG/GdMKIJfh8DdTfjxZg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226437 Archived-At: On Tue 12 Jun 2018, dancol@dancol.org wrote: >>> Date: Mon, 11 Jun 2018 21:14:49 -0700 >>> From: dancol@dancol.org >>> >>> A simple require of a package shouldn't have side effects, especially >>> not >>> ones as drastic as changing the entire appearance of the program. >> >> I think themes are special in this regard: loading a theme activates >> it. >> > > Why did we do it that way? Is it too late to change it? Loading _anything_ > shouldn't activate it. I don't see a need to carve out a special case for > themes. > > At the very least, we should make custom--inhibit-theme-enable a public > variable so people can let-binding something that lets them load theme > code normally without the expectation of serious side effects. The changes you made in commit aabaa9f8c8b7 ("Apply non-user themes only when asked") break use of custom faces with use-package. E.g. in gnus: (use-package gnus :custom-face (gnus-summary-selected ((((class color)) :foreground "Black" :background "PaleGoldenrod"))) :config ;; other setup ) The observed symptom is that the faces are not set correctly as specified after the :custom-face keyword. However if the same buffer is viewed in a new frame then it is displayed with the correct customised faces. This is a regression introduced by this commit - please take a look. AndyM