From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Warnings in mingw64 builds on master Date: Sat, 15 Aug 2020 19:48:56 +0100 Message-ID: <86v9hj7njb.fsf@gmail.com> References: <864kp47t20.fsf@gmail.com> <83a6yvkhby.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26114"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (windows-nt) To: emacs-devel@gnu.org Cancel-Lock: sha1:t+L4bwgRY+GtL8tifPCnIWCV7fA= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 15 20:50:01 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k71Fg-0006eS-4U for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Aug 2020 20:50:00 +0200 Original-Received: from localhost ([::1]:45990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k71Ff-0005f5-56 for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Aug 2020 14:49:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k71En-0004eD-Gi for emacs-devel@gnu.org; Sat, 15 Aug 2020 14:49:05 -0400 Original-Received: from static.214.254.202.116.clients.your-server.de ([116.202.254.214]:42276 helo=ciao.gmane.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k71El-0003bx-Vj for emacs-devel@gnu.org; Sat, 15 Aug 2020 14:49:05 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1k71Ei-0005Yz-MS for emacs-devel@gnu.org; Sat, 15 Aug 2020 20:49:00 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/15 02:23:16 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: 20 X-Spam_score: 2.0 X-Spam_bar: ++ X-Spam_report: (2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253815 Archived-At: On Sat 15 Aug 2020, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Fri, 14 Aug 2020 23:37:27 +0100 >> >> Building master for 64bit mingw64 gives the following warnings: >> >> C:/emacs/git/emacs/master/src/w32reg.c:146:1: warning: function might be >> candidate for attribute 'malloc' [-Wsuggest-attribute=malloc] >> 146 | w32_get_string_resource (void *v_rdb, const char *name, const char *class) >> | ^~~~~~~~~~~~~~~~~~~~~~~ > > That's just noise. There's nothing wrong with the code. Agreed. However it is better to have a clean build than to have pointless warnings, so the real errors stand out. >> C:/emacs/git/emacs/master/src/w32menu.c: In function 'set_frame_menubar': >> C:/emacs/git/emacs/master/src/w32menu.c:326:2: warning: 'memcpy' offset [3, >> 10] from the object at '' is out of the bounds of referenced >> subobject 'contents' with type 'union Lisp_X *[]' at offset 3 >> [-Warray-bounds] >> 326 | memcpy (previous_items, XVECTOR (f->menu_bar_vector)->contents, >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> 327 | previous_menu_items_used * word_size); >> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> In file included from C:/emacs/git/emacs/master/src/w32menu.c:26: >> C:/emacs/git/emacs/master/src/lisp.h:1631:17: note: subobject 'contents' declared here >> 1631 | Lisp_Object contents[FLEXIBLE_ARRAY_MEMBER]; >> | ^~~~~~~~ > > Likewise. > >> C:/emacs/git/emacs/master/src/w32.c: In function '_sys_read_ahead': >> C:/emacs/git/emacs/master/src/w32.c:8785:10: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized] >> 8785 | if (rc == sizeof (char)) >> | ~~~^~~~~~~~~~~~~~~~ > > This is a bug in the compiler you are using: rc _is_ initialized. The is "gcc version 10.2.0 (Rev1, Built by MSYS2 project)" so not exactly old. More silly warnings that it would be better to disable. >> C:/emacs/git/emacs/master/src/image.c:116: warning: macro "PIX_MASK_DRAW" is not used [-Wunused-macros] >> 116 | #define PIX_MASK_DRAW 1 >> | > > This macro is used in the PNG code. Are you building without PNG > support? Yes, as the native image support handles PNG. >> These must have been introduced fairly recently, as the build was clean >> earlier this year. > > Actually, this code was not touched in years, so I'm guessing you > upgraded to a later version of the compiler lately. Yes - it is whatever is current in in the MSYS distro. AndyM