From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: The new keymap functions Date: Wed, 17 Nov 2021 10:10:40 +0200 Organization: LINKOV.NET Message-ID: <86v90r6w3j.fsf@mail.linkov.net> References: <87zgq8sfw3.fsf@gnus.org> <86k0h8ts66.fsf@mail.linkov.net> <87r1bfp72g.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33540"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Emacs developers To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 17 09:21:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnGCC-0008bn-NE for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Nov 2021 09:21:32 +0100 Original-Received: from localhost ([::1]:35076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnGCB-0006TB-Od for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Nov 2021 03:21:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnGBH-0005Xs-VR for emacs-devel@gnu.org; Wed, 17 Nov 2021 03:20:35 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:45591) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnGBF-00013L-TQ for emacs-devel@gnu.org; Wed, 17 Nov 2021 03:20:35 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 31F71FF80C; Wed, 17 Nov 2021 08:20:29 +0000 (UTC) In-Reply-To: <87r1bfp72g.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 17 Nov 2021 08:36:23 +0100") Received-SPF: pass client-ip=217.70.183.199; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279615 Archived-At: >> What about renaming it to `keymap-define'? Then: >> >> (keymap-define "C-c C-c" #'quit-buffer) >> (keymap-set map "C-c C-c" #'quit-buffer) > > I like that all the `keymap-*' functions take a map as the first > parameter (except the commands that have the map "in the name", like > `keymap-global-set'). And using `define-*' for a form that defines > something (and has a (potentially) long body) is a very long-standing > tradition in Emacs, so I'd prefer to keep it as is. This is fine. I see that `define-key' avoids this dilemma by removing `define-' in its replacement `keymap-set' 🙃 The reason why I'm asking this is to know how the corresponding function/macro for repeat-mode should be named in master. And it seems `define-repeat-map' would be the right name.