From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [scratch/igc] 985247b6bee crash on Linux, KDE, Wayland Date: Thu, 05 Sep 2024 17:44:39 +0300 Message-ID: <86v7za2m94.fsf@gnu.org> References: <8734mezkgo.fsf@gmail.com> <87plpis6ff.fsf@protonmail.com> <87bk124aip.fsf@gmail.com> <87h6aus5yz.fsf@protonmail.com> <87y1461frv.fsf@gmail.com> <864j6u47g4.fsf@gnu.org> <8634me447j.fsf@gnu.org> <861q1y437s.fsf@gnu.org> <86wmjq2mr2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1768"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, pipcet@protonmail.com, emacs-devel@gnu.org To: execvy@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 05 16:45:27 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smDji-0000Km-JY for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Sep 2024 16:45:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smDj2-00017b-VQ; Thu, 05 Sep 2024 10:44:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smDj1-00017R-Iw for emacs-devel@gnu.org; Thu, 05 Sep 2024 10:44:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smDj0-0005EM-W8; Thu, 05 Sep 2024 10:44:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=R862d/ulXL4Py8E5dwYS38wYCZtjWRkotUbhAbLZKto=; b=WfHrORsj2Gv5jsyKQZun K67trEMQu+nzUCYcWvHy6VueLEZnPRzCOcFKvKdBjaSn+s3OU7xMQMsrJfRLrc6v6bjHtoOaO4i1B /agMa5SI4C+jBKxhe6vQ/6FkLuT5V7imvk+efCEBJzyrI2Y5cG55Lnvp8YVGY9r3nrQlGKb1EQms8 JQq3YScLoFrovFc6ytq56+YIwgXqday0TzVrPmknPdyNFTrhpcfBYjdsVUgW45THFKUUg99QePPd5 VBxLYOlS0LnYLQkYUmAn/4Z/KnxBxvMQTScviMQgIsH3kqjThFeZTk3q21u3fk+tltQl7WbibGs5j EOUs5CYpZWEzSQ==; In-Reply-To: <86wmjq2mr2.fsf@gnu.org> (message from Eli Zaretskii on Thu, 05 Sep 2024 17:33:53 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323410 Archived-At: > Date: Thu, 05 Sep 2024 17:33:53 +0300 > From: Eli Zaretskii > Cc: execvy@gmail.com, pipcet@protonmail.com, emacs-devel@gnu.org > > > From: Gerd Möllmann > > Cc: execvy@gmail.com, pipcet@protonmail.com, emacs-devel@gnu.org > > Date: Thu, 05 Sep 2024 15:57:50 +0200 > > > > Eli Zaretskii writes: > > > > >> That means FRAME_OUTPUT_DATA can be null during the lifetime of a > > >> frame. If that happens, we'll crash exactly in that way in the new code > > >> for window frames. > > > > > > We never test for FRAME_OUTPUT_DATA being non-NULL in the code, so I > > > don't think I understand why igc.c is different. > > > > Our scan functions can run at arbitrary times, including when > > FRAME_OUTPUT_DATA is still null. > > OK, but if you look at the backtrace, you will see that in this case > the scan functions were run from within code called by > redisplay_internal, so I very much doubt that FRAME_OUTPUT_DATA was > NULL in this case. But ultimately, it is best to see what happens with our own eyes. So, Eval EXEC, next time this happens, please do: (gdb) frame 24 (gdb) p f (gdb) p f->output_data (gdb) p f->output_data.x (gdb) p f->output_data.x->display_info (gdb) p f->output_data.x->display_info->mouse_highlight Here, "frame 24" should get you to this frame: #24 0x0000000000692cd8 in fix_frame (f=0x7fdff9ce8f48, ss=0x7ffcfd2025f8) at /home/exec/Projects/git.savannah.gnu.org/git/emacs/src/igc.c:2068 If it doesn't change "24" to the number of frame where we are in fix_frame on line 2068 of igc.c.