* Re: [Emacs-diffs] emacs-25 85121e0: Allow completion on dynamic module files in load-library
[not found] ` <E1a1KJo-0000mx-L1@vcs.savannah.gnu.org>
@ 2015-11-24 21:12 ` Stefan Monnier
2015-11-25 3:34 ` Eli Zaretskii
2015-11-25 16:47 ` Stephen Leake
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Monnier @ 2015-11-24 21:12 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii
> - (list (completing-read "Load library: "
> - (apply-partially 'locate-file-completion-table
> - load-path
> - (get-load-suffixes)))))
> + (let (completion-ignored-extensions)
> + (list (completing-read "Load library: "
> + (apply-partially 'locate-file-completion-table
> + load-path
> + (get-load-suffixes))))))
Hmm... maybe we should even push this let-binding directly into
locate-file-completion-table.
WDYT?
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] emacs-25 85121e0: Allow completion on dynamic module files in load-library
2015-11-24 21:12 ` [Emacs-diffs] emacs-25 85121e0: Allow completion on dynamic module files in load-library Stefan Monnier
@ 2015-11-25 3:34 ` Eli Zaretskii
2015-11-25 4:01 ` Stefan Monnier
2015-11-25 16:47 ` Stephen Leake
1 sibling, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2015-11-25 3:34 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Tue, 24 Nov 2015 16:12:58 -0500
>
> > - (list (completing-read "Load library: "
> > - (apply-partially 'locate-file-completion-table
> > - load-path
> > - (get-load-suffixes)))))
> > + (let (completion-ignored-extensions)
> > + (list (completing-read "Load library: "
> > + (apply-partially 'locate-file-completion-table
> > + load-path
> > + (get-load-suffixes))))))
>
> Hmm... maybe we should even push this let-binding directly into
> locate-file-completion-table.
> WDYT?
Even if suffixes are nil?
But if you say so, I don't object; I admit I don't fully understand
that function.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] emacs-25 85121e0: Allow completion on dynamic module files in load-library
2015-11-25 3:34 ` Eli Zaretskii
@ 2015-11-25 4:01 ` Stefan Monnier
2015-11-25 17:27 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2015-11-25 4:01 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
>> Hmm... maybe we should even push this let-binding directly into
>> locate-file-completion-table.
>> WDYT?
> Even if suffixes are nil?
> But if you say so, I don't object; I admit I don't fully understand
> that function.
I'm not 100% sure the let-binding is always going to be better when
suffixes is empty, but it's probably no worse.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] emacs-25 85121e0: Allow completion on dynamic module files in load-library
2015-11-24 21:12 ` [Emacs-diffs] emacs-25 85121e0: Allow completion on dynamic module files in load-library Stefan Monnier
2015-11-25 3:34 ` Eli Zaretskii
@ 2015-11-25 16:47 ` Stephen Leake
1 sibling, 0 replies; 5+ messages in thread
From: Stephen Leake @ 2015-11-25 16:47 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Eli Zaretskii, emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> - (list (completing-read "Load library: "
>> - (apply-partially 'locate-file-completion-table
>> - load-path
>> - (get-load-suffixes)))))
>> + (let (completion-ignored-extensions)
>> + (list (completing-read "Load library: "
>> + (apply-partially 'locate-file-completion-table
>> + load-path
>> + (get-load-suffixes))))))
>
> Hmm... maybe we should even push this let-binding directly into
> locate-file-completion-table.
> WDYT?
+1; that would be cleaner
--
-- Stephe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] emacs-25 85121e0: Allow completion on dynamic module files in load-library
2015-11-25 4:01 ` Stefan Monnier
@ 2015-11-25 17:27 ` Eli Zaretskii
0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2015-11-25 17:27 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Tue, 24 Nov 2015 23:01:08 -0500
>
> >> Hmm... maybe we should even push this let-binding directly into
> >> locate-file-completion-table.
> >> WDYT?
> > Even if suffixes are nil?
> > But if you say so, I don't object; I admit I don't fully understand
> > that function.
>
> I'm not 100% sure the let-binding is always going to be better when
> suffixes is empty, but it's probably no worse.
OK, I will do this on master once the change is merged from emacs-25.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-11-25 17:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151124203604.2994.60394@vcs.savannah.gnu.org>
[not found] ` <E1a1KJo-0000mx-L1@vcs.savannah.gnu.org>
2015-11-24 21:12 ` [Emacs-diffs] emacs-25 85121e0: Allow completion on dynamic module files in load-library Stefan Monnier
2015-11-25 3:34 ` Eli Zaretskii
2015-11-25 4:01 ` Stefan Monnier
2015-11-25 17:27 ` Eli Zaretskii
2015-11-25 16:47 ` Stephen Leake
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).